Skip to content

Allow layer_residual_quantiles() to interact with any keys #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
dajmcdon opened this issue Aug 3, 2022 · 1 comment · Fixed by #116
Closed
2 tasks done

Allow layer_residual_quantiles() to interact with any keys #117

dajmcdon opened this issue Aug 3, 2022 · 1 comment · Fixed by #116

Comments

@dajmcdon
Copy link
Contributor

dajmcdon commented Aug 3, 2022

  • The current version on the frosting branch produces residuals ignoring all the keys.
  • The updated version in Intro vignette #116 groups the residuals by key (all of them) before calculating the quantiles.

The update also has an argument in arx_args_list() and flatline_args_list() that determines whether to group by key. But it's currently ignored in #116.

  • Modify the two *_args_list() functions to take some sort of selectors. Do we want these grouped by 1 key, all keys, some subset? The default should be "all", but we should let the user choose more than just "none" (current version) or "all" (updated version in Intro vignette #116)
  • Modify the slather.residual_quantiles() to correctly handle all the cases (no grouping, group_by selected keys, group_by all keys).
@dajmcdon
Copy link
Contributor Author

Closed by #116

@dajmcdon dajmcdon linked a pull request Aug 11, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant