Skip to content

Refactor layer_naomit() #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dajmcdon opened this issue Jul 20, 2022 · 0 comments
Open

Refactor layer_naomit() #107

dajmcdon opened this issue Jul 20, 2022 · 0 comments
Labels
P1 high priority

Comments

@dajmcdon
Copy link
Contributor

Refactors layer_naomit() to make sure that it returns NAs for the targets but gets rid of the rest. As I think about it, we actually shouldn't be dropping NAs in the predictions per se, but rather only returning the rows that have meaningful predictions (even if these are NA).

So far, it's been coincidental that the rows with NA are not meaningful. But this isn't foolproof. It may be that NAs are meaningful (as in #106) but it's also possible that they aren't (often as a result of lagging the predictors).

@dajmcdon dajmcdon added the P1 high priority label Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 high priority
Projects
None yet
Development

No branches or pull requests

1 participant