fix: address n_train and ahead mismatch #290

Author: dshemetov

R/layer_residual_quantiles.R

@@ -123,6 +123,10 @@ slather.layer_residual_quantiles <-
           probs = object$quantile_levels, na.rm = TRUE
         ))
       )
+    # Check for NA
+    if (any(sapply(r$dstn, is.na))) {
+      cli::cli_abort("Quantiles could not be calculated due to missing residuals. Check your n_train and ahead values.")
+    }
 
     estimate <- components$predictions$.pred
     res <- tibble::tibble(

tests/testthat/test-layer_residual_quantiles.R

@@ -98,3 +98,10 @@ test_that("Canned forecasters work with / without", {
     )
   )
 })
+
+test_that("flatline_forecaster correctly errors when n_training < ahead", {
+  expect_error(
+    flatline_forecaster(jhu, "death_rate", args_list = flatline_args_list(ahead = 10, n_training = 9)),
+    "Check your n_train and ahead values"
+  )
+})

tests/testthat/test-target_date_bug.R

@@ -1,3 +1,6 @@
+# These tests address #290:
+# https://github.com/cmu-delphi/epipredict/issues/290
+
 library(dplyr)
 train <- jhu_csse_daily_subset |>
   filter(time_value >= as.Date("2021-10-01")) |>
@@ -13,7 +16,6 @@ test_that("flatline determines target_date where forecast_date exists", {
       ahead = 1L
     )
   )
-
   # previously, if target_date existed, it could be
   # erroneously incremented by the ahead
   expect_identical(
@@ -24,9 +26,6 @@ test_that("flatline determines target_date where forecast_date exists", {
     flat$predictions$forecast_date,
     rep(as.Date("2021-12-31"), ngeos)
   )
-
-  # potentially resulted in NA predictions
-  # see #290 https://github.com/cmu-delphi/epipredict/issues/290
   expect_true(all(!is.na(flat$predictions$.pred_distn)))
   expect_true(all(!is.na(flat$predictions$.pred)))
 })
@@ -50,9 +49,6 @@ test_that("arx_forecaster determines target_date where forecast_date exists", {
     arx$predictions$forecast_date,
     rep(as.Date("2021-12-31"), ngeos)
   )
-
-  # potentially resulted in NA predictions
-  # see #290 https://github.com/cmu-delphi/epipredict/issues/290
   expect_true(all(!is.na(arx$predictions$.pred_distn)))
   expect_true(all(!is.na(arx$predictions$.pred)))
 })
@@ -67,7 +63,6 @@ test_that("arx_classifier determines target_date where forecast_date exists", {
       ahead = 1L
     )
   )
-
   # previously, if target_date existed, it could be
   # erroneously incremented by the ahead
   expect_identical(
@@ -78,8 +73,5 @@ test_that("arx_classifier determines target_date where forecast_date exists", {
     arx$predictions$forecast_date,
     rep(as.Date("2021-12-31"), ngeos)
   )
-
-  # potentially resulted in NA predictions
-  # see #290 https://github.com/cmu-delphi/epipredict/issues/290
   expect_true(all(!is.na(arx$predictions$.pred_class)))
 })