Skip to content

Commit da6489f

Browse files
committed
tests pass
1 parent f04264c commit da6489f

File tree

3 files changed

+23
-8
lines changed

3 files changed

+23
-8
lines changed

NAMESPACE

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,8 @@ S3method(snap,default)
9292
S3method(snap,dist_default)
9393
S3method(snap,dist_quantiles)
9494
S3method(snap,distribution)
95+
S3method(vec_ptype_abbr,dist_quantiles)
96+
S3method(vec_ptype_full,dist_quantiles)
9597
export("%>%")
9698
export(add_epi_recipe)
9799
export(add_frosting)
@@ -155,8 +157,6 @@ export(step_lag_difference)
155157
export(step_population_scaling)
156158
export(step_training_window)
157159
export(validate_layer)
158-
export(vec_ptype_abbr.dist_quantiles)
159-
export(vec_ptype_full.dist_quantiles)
160160
import(distributional)
161161
import(epiprocess)
162162
import(parsnip)
@@ -194,3 +194,12 @@ importFrom(stats,residuals)
194194
importFrom(tibble,as_tibble)
195195
importFrom(tibble,is_tibble)
196196
importFrom(tibble,tibble)
197+
importFrom(vctrs,as_list_of)
198+
importFrom(vctrs,field)
199+
importFrom(vctrs,new_rcrd)
200+
importFrom(vctrs,new_vctr)
201+
importFrom(vctrs,vec_cast)
202+
importFrom(vctrs,vec_data)
203+
importFrom(vctrs,vec_ptype_abbr)
204+
importFrom(vctrs,vec_ptype_full)
205+
importFrom(vctrs,vec_recycle_common)

R/dist_quantiles.R

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1+
#' @importFrom vctrs field vec_cast new_rcrd
12
new_quantiles <- function(values = double(), quantile_values = double()) {
23
arg_is_probabilities(quantile_values)
34

45
vec_cast(values, double())
56
vec_cast(quantile_values, double())
67
stopifnot(length(values) == length(quantile_values))
7-
stopifnot(!vec_duplicate_any(quantile_values))
8+
stopifnot(!vctrs::vec_duplicate_any(quantile_values))
89
if (is.unsorted(quantile_values)) {
9-
o <- vec_order(quantile_values)
10+
o <- vctrs::vec_order(quantile_values)
1011
values <- values[o]
1112
quantile_values <- quantile_values[o]
1213
}
@@ -20,6 +21,8 @@ new_quantiles <- function(values = double(), quantile_values = double()) {
2021
}
2122

2223

24+
25+
#' @importFrom vctrs vec_ptype_abbr vec_ptype_full
2326
#' @export
2427
vec_ptype_abbr.dist_quantiles <- function(x, ...) "dist_qntls"
2528
#' @export
@@ -51,6 +54,7 @@ format.dist_quantiles <- function(x, digits = 2, ...) {
5154
#'
5255
#' dist_quantiles(1:4, 1:4 / 5)
5356
#' dist_quantiles(1:4, c(1, 3, 2, 4) / 5)
57+
#' @importFrom vctrs as_list_of vec_recycle_common new_vctr
5458
dist_quantiles <- function(values, quantile_values) {
5559
if (!is.list(values)) values <- list(values)
5660
if (!is.list(quantile_values)) quantile_values <- list(quantile_values)
@@ -114,10 +118,11 @@ extrapolate_quantiles <- function(x, probs, ...) {
114118
}
115119

116120
#' @export
121+
#' @importFrom vctrs vec_data
117122
extrapolate_quantiles.distribution <- function(x, probs, ...) {
118123
arg_is_probabilities(probs)
119124
dstn <- lapply(vec_data(x), extrapolate_quantiles, p = probs, ...)
120-
distributional:::wrap_dist(dstn)
125+
new_vctr(dstn, vars = NULL, class = "distribution")
121126
}
122127

123128
#' @export
@@ -157,7 +162,8 @@ nested_quantiles <- function(x) {
157162
map(
158163
x,
159164
~ distributional::parameters(.x) %>%
160-
tidyr::unnest(tidyselect::everything())
165+
tidyr::unnest(tidyselect::everything()) %>%
166+
mutate(values = unname(values))
161167
)
162168
}
163169

@@ -418,7 +424,7 @@ Ops.dist_quantiles <- function(e1, e2) {
418424
#' @method is.na distribution
419425
#' @export
420426
is.na.distribution <- function(x) {
421-
sapply(vctrs::vec_data(x), is.na)
427+
sapply(vec_data(x), is.na)
422428
}
423429

424430
#' @method is.na dist_quantiles

tests/testthat/test-extract_argument.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ test_that("layer argument extractor works", {
77
expect_error(extract_argument(f$layers[[1]], "uhoh", "bubble"))
88
expect_error(extract_argument(f$layers[[1]], "layer_predict", "bubble"))
99
expect_identical(
10-
extract_argument(f$layers[[2]], "layer_residual_quantiles", "probs"),
10+
extract_argument(f$layers[[2]], "layer_residual_quantiles", "quantile_values"),
1111
c(0.0275, 0.9750)
1212
)
1313

0 commit comments

Comments
 (0)