Skip to content

Commit 0c0a5e8

Browse files
authored
Merge pull request #311 from cmu-delphi/ds/dev-doc
doc: add reminder about pinning epiprocess version in PR template
2 parents 944a562 + ed02c20 commit 0c0a5e8

File tree

2 files changed

+17
-25
lines changed

2 files changed

+17
-25
lines changed

.github/pull_request_template.md

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,23 @@
22

33
Please:
44

5-
- [ ] Make sure this PR is against "dev", not "main".
6-
- [ ] Request a review from one of the current epipredict main reviewers:
7-
dajmcdon.
8-
- [ ] Makes sure to bump the version number in `DESCRIPTION` and `NEWS.md`.
9-
Always increment the patch version number (the third number), unless you are
10-
making a release PR from dev to main, in which case increment the minor
11-
version number (the second number).
12-
- [ ] Describe changes made in NEWS.md, making sure breaking changes
13-
(backwards-incompatible changes to the documented interface) are noted.
14-
Collect the changes under the next release number (e.g. if you are on
15-
0.7.2, then write your changes under the 0.8 heading).
5+
- [ ] Make sure this PR is against "dev", not "main".
6+
- [ ] Request a review from one of the current epipredict main reviewers:
7+
dajmcdon.
8+
- [ ] Make sure to bump the version number in `DESCRIPTION` and `NEWS.md`.
9+
Always increment the patch version number (the third number), unless you are
10+
making a release PR from dev to main, in which case increment the minor
11+
version number (the second number).
12+
- [ ] Describe changes made in NEWS.md, making sure breaking changes
13+
(backwards-incompatible changes to the documented interface) are noted.
14+
Collect the changes under the next release number (e.g. if you are on
15+
0.7.2, then write your changes under the 0.8 heading).
16+
- [ ] Consider pinning the `epiprocess` version in the `DESCRIPTION` file if
17+
- You anticipate breaking changes in `epiprocess` soon
18+
- You want to co-develop features in `epipredict` and `epiprocess`
1619

1720
### Change explanations for reviewer
1821

1922
### Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch
2023

21-
- Resolves #{issue number}
24+
- Resolves #{issue number}

DEVELOPMENT.md

Lines changed: 2 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,26 +30,15 @@ pkgdown::build_site(preview=TRUE)
3030
The `main` version is available at `file:///<local path>/epidatr/epipredict/index.html` and `dev` at `file:///<local path>/epipredict/docs/dev/index.html`.
3131

3232
You can also build the docs manually and launch the site with python. From the terminal, this looks like
33+
3334
```bash
3435
R -e 'devtools::document()'
3536
python -m http.server -d docs
3637
```
3738

3839
## Versioning
3940

40-
Please follow the guidelines in the PR template document (reproduced here):
41-
42-
- [ ] Make sure this PR is against "dev", not "main".
43-
- [ ] Request a review from one of the current epipredict main reviewers:
44-
dajmcdon.
45-
- [ ] Makes sure to bump the version number in `DESCRIPTION` and `NEWS.md`.
46-
Always increment the patch version number (the third number), unless you are
47-
making a release PR from dev to main, in which case increment the minor
48-
version number (the second number).
49-
- [ ] Describe changes made in NEWS.md, making sure breaking changes
50-
(backwards-incompatible changes to the documented interface) are noted.
51-
Collect the changes under the next release number (e.g. if you are on
52-
0.7.2, then write your changes under the 0.8 heading).
41+
Please follow the guidelines in the [PR template document](.github/pull_request_template.md).
5342

5443
## Release process
5544

0 commit comments

Comments
 (0)