Skip to content

classic only endpoints should return plain JSON, but fromJSON auto converts to data.frame #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dshemetov opened this issue Apr 20, 2023 · 0 comments · Fixed by #99
Closed

classic only endpoints should return plain JSON, but fromJSON auto converts to data.frame #88

dshemetov opened this issue Apr 20, 2023 · 0 comments · Fixed by #99
Assignees
@dshemetov
Labels
question Further information is requested triage Should assign/revisit priority level, other tags

Comments

@dshemetov
Copy link
Contributor

Bug: delphi should be a list / nested structure, but fetch_classic doesn't actually respect this and turns it into a data frame. The culprit is probably

  r <- httr::content(res, "text", encoding = "UTF-8")
  m <- jsonlite::fromJSON(r)

vs. delphi_epidata.R's

content(res, 'parsed')

Originally posted by @brookslogan in #72 (comment)
@dshemetov dshemetov added triage Should assign/revisit priority level, other tags question Further information is requested labels Apr 24, 2023
@dshemetov dshemetov mentioned this issue May 6, 2023
Merged
1 task
@dshemetov dshemetov self-assigned this May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dshemetov dshemetov

Labels
question Further information is requested triage Should assign/revisit priority level, other tags
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate fetch interfaces cmu-delphi/epidatr
1 participant
@dshemetov