Skip to content

Make fetch_tbl and fetch_df compatible with vroom upgrade #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brookslogan opened this issue Oct 27, 2022 · 2 comments
Closed

Make fetch_tbl and fetch_df compatible with vroom upgrade #60

brookslogan opened this issue Oct 27, 2022 · 2 comments
Labels
P2 low priority

Comments

@brookslogan
Copy link
Contributor

brookslogan commented Oct 27, 2022 •
edited
Loading

Using either of these generates:

Error: The `file` argument of `vroom()` must use `I()` for literal data as of vroom 1.5.0.

#37 looks like it fixes this for fetch_tbl but also needs applied to fetch_df [fetch_df dispatches to fetch_tbl].
@brookslogan brookslogan added the P0 Top priority label Oct 27, 2022
@brookslogan brookslogan mentioned this issue Oct 27, 2022
Closed
@brookslogan brookslogan added P2 low priority and removed P0 Top priority labels Jan 23, 2023
@brookslogan
Copy link
Contributor Author

Degrading priority. This only appears to be an error or even a warning for users when using nondefault options(lifecycle_verbosity=.....) settings, as it's based on lifecycle::deprecate_soft. We should still address the deprecation, but it's not as urgent.

@dshemetov
Copy link
Contributor

Fixed by #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dshemetov @brookslogan