Skip to content

consider more performance CSV parsing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sgratzl opened this issue Jul 21, 2021 · 1 comment
Closed

consider more performance CSV parsing #6

sgratzl opened this issue Jul 21, 2021 · 1 comment
Labels
enhancement New feature or request P3 very low priority

Comments

@sgratzl
Copy link
Member

sgratzl commented Jul 21, 2021

tibble::as_tibble(data.table::setDF(data.table::fread(csv.result))) is much faster than readr::read_csv(csv.result) . For one query I tried the savings were 10% of the fetch time. (Note that fread has different column type inference rules; e.g., giving some type of numeric geo_value results for both of the above, but we probably want character or factor output.)

@dshemetov
Copy link
Contributor

Closing until we get reports of parsing being a bottleneck

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P3 very low priority
Projects
None yet
Development

No branches or pull requests

3 participants