Skip to content

Make CI fail on check warnings, not just errors #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #90
capnrefsmmat opened this issue Aug 16, 2023 · 0 comments · Fixed by #155
Closed
Tracked by #90

Make CI fail on check warnings, not just errors #148

capnrefsmmat opened this issue Aug 16, 2023 · 0 comments · Fixed by #155
Labels
triage Should assign/revisit priority level, other tags

Comments

@capnrefsmmat
Copy link
Contributor

Currently the CI is set to allow check warnings:

- uses: r-lib/actions/check-r-package@v2
env:
DELPHI_EPIDATA_KEY: ${{ secrets.SECRET_EPIPROCESS_GHACTIONS_DELPHI_EPIDATA_KEY }}
with:
args: 'c("--no-manual", "--as-cran")'
error-on: '"error"'

However, CRAN generally does not accept packages with check warnings unless you have a very good reason, so we should change this to reject warnings as well -- as soon as we fix our existing warnings, such as in #147.

@dshemetov dshemetov added the triage Should assign/revisit priority level, other tags label Aug 21, 2023
@dshemetov dshemetov mentioned this issue Aug 23, 2023
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Should assign/revisit priority level, other tags
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants