Skip to content

Consider fetching by default? #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #90
dshemetov opened this issue Jul 26, 2023 · 4 comments · Fixed by #156
Closed
Tracked by #90

Consider fetching by default? #144

dshemetov opened this issue Jul 26, 2023 · 4 comments · Fixed by #156
Labels
enhancement New feature or request P0 Top priority question Further information is requested

Comments

@dshemetov
Copy link
Contributor

No description provided.

@dshemetov dshemetov added enhancement New feature or request question Further information is requested P0 Top priority labels Jul 26, 2023
@dshemetov dshemetov mentioned this issue Jul 26, 2023
37 tasks
@capnrefsmmat
Copy link
Contributor

Is there any circumstance where you'd want to manipulate the call object? Or do we anticipate people will run fetch() every single time?

In principle I think our API queries always return the same response for a given input, so I don't see people calling fetch() multiple times on the same call, and that'd be the only other reason I can think of for keeping it separate.

@dshemetov
Copy link
Contributor Author

One thing I liked about the current interface is that it helps debugging - you can always look at the URL and see if it's been mangled in some way.

We also have the with_base_url() modifier to adjust the base url of a call (e.g. staging API). So another thing that's aimed at development.

@dsweber2
Copy link
Contributor

There's a couple of arguments that can currently get passed to fetch which would need to be integrated into each endpoint, which feels like awkward boilerplate, at least from a package dev perspective. I suppose good use of ... could cover that.

@dshemetov
Copy link
Contributor Author

dshemetov commented Aug 23, 2023

After today's discussion, it seems that we're moving forward with this integration using a default args list function fetch_args_list().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P0 Top priority question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants