Skip to content

Address build-args typo in ci #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brookslogan opened this issue Jun 9, 2023 · 1 comment · Fixed by #146
Closed

Address build-args typo in ci #124

brookslogan opened this issue Jun 9, 2023 · 1 comment · Fixed by #146
Assignees
Labels
bug Something isn't working good first issue Good for newcomers P1 medium priority

Comments

@brookslogan
Copy link
Contributor

E.g., here. "Warning: Unexpected input(s) 'build-args', valid inputs are ['args', 'build_args', 'error-on', 'check-dir', 'working-directory', 'upload-snapshots', 'upload-results']"

@brookslogan brookslogan added bug Something isn't working good first issue Good for newcomers triage Should assign/revisit priority level, other tags labels Jun 9, 2023
@dshemetov
Copy link
Contributor

That line should be removed anyhow - it's better to build vignettes in the CI, as it acts as another sanity check on the package.

@dsweber2 dsweber2 self-assigned this Jun 16, 2023
@dshemetov dshemetov added P1 medium priority and removed triage Should assign/revisit priority level, other tags labels Jul 18, 2023
This was referenced Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers P1 medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants