Skip to content

clean up warnings in tests #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melange396 opened this issue Oct 4, 2022 · 1 comment
Open

clean up warnings in tests #992

melange396 opened this issue Oct 4, 2022 · 1 comment
Labels
code health readability, maintainability, best practices, etc devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc tests integration & unit testing, bug triage and prevention

Comments

@melange396
Copy link
Collaborator

deprecation warnings are artifacts from doing version updates, its best to fix these before they stop being warnings and become errors. the current warnings output is:

=============================== warnings summary ===============================
repos/delphi/delphi-epidata/integrations/acquisition/covidcast/test_csv_uploading.py::CsvUploadingTests::test_uploading
  /usr/local/lib/python3.8/site-packages/pandas/core/indexing.py:1637: SettingWithCopyWarning:
  A value is trying to be set on a copy of a slice from a DataFrame

  See the caveats in the documentation: https://pandas.pydata.org/pandas-docs/stable/user_guide/indexing.html#returning-a-view-versus-a-copy
    self._setitem_single_block(indexer, value, name)

repos/delphi/delphi-epidata/integrations/acquisition/covidcast_nowcast/test_csv_uploading.py::CsvUploadingTests::test_duplicate_row
repos/delphi/delphi-epidata/integrations/acquisition/covidcast_nowcast/test_csv_uploading.py::CsvUploadingTests::test_duplicate_row
repos/delphi/delphi-epidata/integrations/acquisition/covidcast_nowcast/test_csv_uploading.py::CsvUploadingTests::test_uploading
  /usr/local/lib/python3.8/site-packages/pandas/io/sql.py:1429: SADeprecationWarning: The Engine.run_callable() method is deprecated and will be removed in a future release.  Use the Engine.begin() context manager instead. (deprecated since: 1.4)
    return self.connectable.run_callable(


@melange396 melange396 added code health readability, maintainability, best practices, etc devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc tests integration & unit testing, bug triage and prevention labels Oct 6, 2022
@dshemetov
Copy link
Contributor

dshemetov commented Oct 8, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health readability, maintainability, best practices, etc devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc tests integration & unit testing, bug triage and prevention
Projects
None yet
Development

No branches or pull requests

2 participants