Skip to content

Consider adding COVIDcast support for HHS regions #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krivard opened this issue Aug 13, 2020 · 5 comments
Closed

Consider adding COVIDcast support for HHS regions #192

krivard opened this issue Aug 13, 2020 · 5 comments
Labels
Engineering Used to filter issues when synching with Asana good first issue

Comments

@krivard
Copy link
Contributor

krivard commented Aug 13, 2020

Currently, data ingestion accepts the following geographical types:

  • county
  • hrr
  • msa
  • dma
  • state

We currently have an indicator waiting in the wings whose ideal geographical type is HHS region. To begin serving it from the API, ingestion needs to know how to validate HHS region ids.

Further reading:

@dfarrow0
Copy link
Contributor

dfarrow0 commented Oct 7, 2020

Lots of the flu work involves HHS and Census regions. See https://github.com/cmu-delphi/utils/blob/main/src/geo/locations.py

Regions are nice to work with because they're just sets of states. If you have a signal at the state level, it's trivial to aggregate it up to the HHS or Census level.

The epidata API defines the following region ids: https://github.com/cmu-delphi/delphi-epidata/blob/main/labels/regions.txt


@krivard is this issue the only thing blocking the covidnet source?

@krivard
Copy link
Contributor Author

krivard commented Oct 7, 2020

If you have a signal at the state level, it's trivial to aggregate it up to the HHS or Census level.

Just to clarify, aggregation does not happen in this codebase; this ticket is solely about supporting HHS region ids during COVIDcast acquisition and adding associated tests.

@dfarrow0 No; I've written up the remaining COVIDnet work in a new issue to avoid confusion with the other CDC hospital data.

@dshemetov
Copy link
Contributor

@krivard just ran across this issue. GeoMapper supports state_code -> hhs_region_number mappings now.

@SumitDELPHI SumitDELPHI added the Engineering Used to filter issues when synching with Asana label Dec 2, 2020
@sgratzl
Copy link
Member

sgratzl commented May 14, 2021

can we close this?

@krivard
Copy link
Contributor Author

krivard commented May 14, 2021

Yep; fixed in #314

@krivard krivard closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Used to filter issues when synching with Asana good first issue
Projects
None yet
Development

No branches or pull requests

5 participants