Skip to content

Consider pinning github runner image version #1575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melange396 opened this issue Jan 21, 2025 · 0 comments
Open

Consider pinning github runner image version #1575

melange396 opened this issue Jan 21, 2025 · 0 comments
Labels
chore code health readability, maintainability, best practices, etc dependencies Pull requests that update a dependency file devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc Engineering Used to filter issues when synching with Asana

Comments

@melange396
Copy link
Collaborator

Instead of using a runner image of ubuntu-latest, use a specific one, such as ubuntu-22.04. Using ubuntu-latest sets us up for occasional updates to its runtime environment (a recent one can be seen in actions/runner-images#10636), and these can have significant changes with deep ramifications.

Pros:

  • provides a stable host platform without surprises
  • can be tailored to reflect our production environment for consistency
  • looks like it wouldve saved us from the problem discussed and addressed in fix unittest.mock import error #1574

Cons:

  • we might miss out on "free" performance improvements or security fixes (though i dont think either is really a big concern at this point)
  • we will still need to bump the version(s) at some point in the [distant?] future when the image we select inevitably gets deprecated
  • itll be a pain to do -- searching for "ubuntu-latest" across all of the org's repositories, shows hits in 88 files!
@melange396 melange396 added chore code health readability, maintainability, best practices, etc dependencies Pull requests that update a dependency file devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc Engineering Used to filter issues when synching with Asana labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore code health readability, maintainability, best practices, etc dependencies Pull requests that update a dependency file devops building, running, deploying, environment stuff, handy utils, repository-related, engineer QoL, etc Engineering Used to filter issues when synching with Asana
Projects
None yet
Development

No branches or pull requests

1 participant