Skip to content

covidcast endpoint - inconsistent handling of ISO format dates #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dshemetov opened this issue Apr 27, 2023 · 3 comments · Fixed by #1284
Closed

covidcast endpoint - inconsistent handling of ISO format dates #1153

dshemetov opened this issue Apr 27, 2023 · 3 comments · Fixed by #1284
Assignees

Comments

@krivard
Copy link
Contributor

krivard commented Apr 28, 2023

The ISO format for ranges is YYYY-MM-DD--YYYY-MM-DD (two dashes) which in theory we should accept but it looks like that is also not working, e.g.

https://delphi.cmu.edu/epidata//covidcast/?data_source=hhs&signals=confirmed_admissions_influenza_1d_prop_7dav&time_type=day&geo_type=state&time_values=2021-01-02--2021-01-02&geo_values=ca

vs

https://delphi.cmu.edu/epidata//covidcast/?data_source=hhs&signals=confirmed_admissions_influenza_1d_prop_7dav&time_type=day&geo_type=state&time_values=20210102-20210102&geo_values=ca

  • We should return an error message if someone attempts an ISO range with only one dash
  • We should handle ISO ranges the same way as YYYYMMDD ranges

@melange396
Copy link
Collaborator

The ISO format for ranges is YYYY-MM-DD--YYYY-MM-DD (two dashes) which in theory we should accept

Indeed, this is supposed to handle that ISO range format, but is either malfunctioning or is not in the processing chain for the time_values argument on that endpoint.

@dmytrotsko dmytrotsko self-assigned this Aug 25, 2023
@dmytrotsko dmytrotsko linked a pull request Aug 30, 2023 that will close this issue
3 tasks
@dmytrotsko
Copy link
Contributor

PR with fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants