Skip to content

Commit 4136db4

Browse files
committed
Add and repair tests supporting covidcast geo types
1 parent cae510f commit 4136db4

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

integrations/client/test_delphi_epidata.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ def test_geo_value(self):
218218
# insert placeholder data: three counties, three MSAs
219219
N = 3
220220
rows = [
221-
CovidcastTestRow.make_default_row(geo_type="fips", geo_value=FIPS[i], value=i)
221+
CovidcastTestRow.make_default_row(geo_type="county", geo_value=FIPS[i], value=i)
222222
for i in range(N)
223223
] + [
224224
CovidcastTestRow.make_default_row(geo_type="msa", geo_value=MSA[i], value=i*10)
@@ -245,7 +245,7 @@ def fetch(geo):
245245
self.assertEqual(request['epidata'], [counties[0]])
246246
# test fetch a specific yet not existing region
247247
request = fetch('55555')
248-
self.assertEqual(request['message'], 'Invalid geo_value(s) 55555 for the requested geo_type fips')
248+
self.assertEqual(request['message'], 'Invalid geo_value(s) 55555 for the requested geo_type county')
249249
# test fetch a multiple regions
250250
request = fetch([FIPS[0], FIPS[1]])
251251
self.assertEqual(request['message'], 'success')
@@ -256,10 +256,10 @@ def fetch(geo):
256256
self.assertEqual(request['epidata'], [counties[0], counties[2]])
257257
# test fetch a multiple regions but one is not existing
258258
request = fetch([FIPS[0], '55555'])
259-
self.assertEqual(request['message'], 'Invalid geo_value(s) 55555 for the requested geo_type fips')
259+
self.assertEqual(request['message'], 'Invalid geo_value(s) 55555 for the requested geo_type county')
260260
# test fetch a multiple regions but specify no region
261261
request = fetch([])
262-
self.assertEqual(request['message'], 'geo_value is empty for the requested geo_type fips!')
262+
self.assertEqual(request['message'], 'geo_value is empty for the requested geo_type county!')
263263
# test fetch a region with no results
264264
request = fetch([FIPS[3]])
265265
self.assertEqual(request['message'], 'no results')
@@ -326,7 +326,7 @@ def test_async_epidata(self):
326326
# insert placeholder data: three counties, three MSAs
327327
N = 3
328328
rows = [
329-
CovidcastTestRow.make_default_row(geo_type="fips", geo_value=FIPS[i-1], value=i)
329+
CovidcastTestRow.make_default_row(geo_type="county", geo_value=FIPS[i-1], value=i)
330330
for i in range(N)
331331
] + [
332332
CovidcastTestRow.make_default_row(geo_type="msa", geo_value=MSA[i-1], value=i*10)

tests/server/test_params.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,10 @@ def test_parse_geo_arg(self):
9494
self.assertEqual(parse_geo_arg(), [GeoSet("fips", True)])
9595
with app.test_request_context(f"/?geo=fips:{FIPS[0]}"):
9696
self.assertEqual(parse_geo_arg(), [GeoSet("fips", [FIPS[0]])])
97+
with self.subTest("covidcast"):
98+
for geo_type in "county dma hhs hrr msa nation state".split():
99+
with app.test_request_context(f"/?geo={geo_type}:*"):
100+
self.assertEqual(parse_geo_arg(), [GeoSet(geo_type, True)])
97101
with self.subTest("single list"):
98102
with app.test_request_context(f"/?geo=fips:{FIPS[0]},{FIPS[1]}"):
99103
self.assertEqual(parse_geo_arg(), [GeoSet("fips", [FIPS[0], FIPS[1]])])

0 commit comments

Comments
 (0)