Skip to content

USAFacts is failing checks in main #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krivard opened this issue Nov 2, 2020 · 0 comments · Fixed by #421
Closed

USAFacts is failing checks in main #419

krivard opened this issue Nov 2, 2020 · 0 comments · Fixed by #421
Assignees
@sgsmob
Labels
bug Something isn't working

Comments

@krivard
Copy link
Contributor

krivard commented Nov 2, 2020

USAFacts is failing tests in main, probably due to a hamhanded conflict resolution I installed on Friday 😞

Linter errors:

env/bin/pylint delphi_usafacts
************* Module delphi_usafacts.geo
delphi_usafacts/geo.py:28:42: E0602: Undefined variable 'STATE_TO_FIPS' (undefined-variable)
************* Module delphi_usafacts.pull
delphi_usafacts/pull.py:78:18: E0602: Undefined variable 'pop_df' (undefined-variable)

(these cause commensurate errors in tests as well)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgsmob sgsmob

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove extraneous functions and calls from usafacts sgsmob/covidcast-indicators
2 participants
@krivard @sgsmob