You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
using the wildcard import can introduce problems when debugging. it puts objects into scope without being declared or assigned, and hunting those down can be difficult. this can be even worse if multiple imports have name collisions.
for example, instead of: delphi_emr_hosp.constants import *
we can use: delphi_emr_hosp.constants import NA, SIGNALS
or even: from delphi_emr_hosp import constants as c # then use c.NA and c.SIGNALS
the choice is up to the implementer for brevity's or readability's sake.
there are many of these in the repo
The text was updated successfully, but these errors were encountered:
emr_hosp is no longer active per footnote in #306, and the only other occurrences of these in non-test code are in the combo signal which I've hopefully addressed in #346. I see 3 other occurences: 2 in claims_hosp tests and 1 in cdc_covidnet tests, which should also be a quick fix
using the wildcard import can introduce problems when debugging. it puts objects into scope without being declared or assigned, and hunting those down can be difficult. this can be even worse if multiple imports have name collisions.
for example, instead of:
delphi_emr_hosp.constants import *
we can use:
delphi_emr_hosp.constants import NA, SIGNALS
or even:
from delphi_emr_hosp import constants as c # then use c.NA and c.SIGNALS
the choice is up to the implementer for brevity's or readability's sake.
there are many of these in the repo
The text was updated successfully, but these errors were encountered: