Skip to content

Commit d009953

Browse files
Ananya Ashish JoshiAnanya Ashish Joshi
Ananya Ashish Joshi
authored and
Ananya Ashish Joshi
committed
added a check on signal so that outlier test is only run on cases and deaths
1 parent 7cd0306 commit d009953

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

validator/delphi_validator/validate.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -869,6 +869,7 @@ def validate(self, export_dir):
869869
"""
870870

871871
# Get relevant data file names and info.
872+
872873
export_files = read_filenames(export_dir)
873874
date_filter = make_date_filter(self.start_date, self.end_date)
874875

@@ -963,14 +964,21 @@ def validate(self, export_dir):
963964
if geo_sig_api_df is None:
964965
continue
965966

966-
earliest_available_date = geo_sig_df["time_value"].min()
967+
967968

968969
# Outlier dataframe
969-
outlier_start_date = earliest_available_date - outlier_lookbehind
970-
outlier_end_date = earliest_available_date - timedelta(days=1)
971-
outlier_api_df = geo_sig_api_df.query \
972-
('time_value <= @outlier_end_date & time_value >= @outlier_start_date')
973-
self.check_positive_negative_spikes(source_df, outlier_api_df, geo_type, signal_type)
970+
if (signal_type in ["confirmed_7dav_cumulative_num", "confirmed_7dav_incidence_num", \
971+
"confirmed_cumulative_num", "confirmed_incidence_num", "deaths_7dav_cumulative_num", \
972+
"deaths_cumulative_num"]):
973+
earliest_available_date = geo_sig_df["time_value"].min()
974+
source_df = geo_sig_df.query(
975+
'time_value <= @date_list[-1] & time_value >= @date_list[0]')
976+
print(source_df)
977+
outlier_start_date = earliest_available_date - outlier_lookbehind
978+
outlier_end_date = earliest_available_date - timedelta(days=1)
979+
outlier_api_df = geo_sig_api_df.query \
980+
('time_value <= @outlier_end_date & time_value >= @outlier_start_date')
981+
self.check_positive_negative_spikes(source_df, outlier_api_df, geo_type, signal_type)
974982

975983
# Check data from a group of dates against recent (previous 7 days,
976984
# by default) data from the API.

0 commit comments

Comments
 (0)