Skip to content

Commit bae28ab

Browse files
authored
Merge pull request #202 from cmu-delphi/resolve-main-deploy-jhu
Resolve merge conflicts between main and deploy-jhu
2 parents 80d9d75 + 975dd54 commit bae28ab

File tree

164 files changed

+120148
-18
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

164 files changed

+120148
-18
lines changed

README.md

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,15 @@ Each subdirectory contained here that is named after an indicator has specific d
1010

1111
**tl;dr**
1212

13-
- Create your new indicator branch from `main`.
14-
- Build it using the appropriate template, following the guidelines in the included README.md and REVIEW.md files.
15-
- Make some stuff!
16-
- When your stuff works, push your `dev-*` branch to remote for review.
17-
- Consult with a platform engineer for the remaining production setup needs. They will create a branch called `deploy-*` for your indicator.
18-
- Initiate a pull request against this new branch.
19-
- If your peers like it and Jenkins approves, deploy your changes by merging the PR.
20-
- Rejoice!
13+
1. Create your new indicator branch from `main`.
14+
2. Build it using the appropriate template, following the guidelines in the included README.md and REVIEW.md files.
15+
3. Make some stuff!
16+
4. When your stuff works, push your `dev-*` branch to remote for review.
17+
5. Consult with a platform engineer for the remaining production setup needs. They will create a branch called `deploy-*` for your indicator.
18+
6. Initiate a pull request against this new branch.
19+
7. Following [the source documentation template](https://github.com/cmu-delphi/delphi-epidata/blob/main/docs/api/covidcast-signals/_source-template.md), create public API documentation for the source. You can submit this as a pull request against the delphi-epidata repository.
20+
8. If your peers like the code, the documentation is ready, and Jenkins approves, deploy your changes by merging the PR.
21+
9. Rejoice!
2122

2223
### Starting out
2324

@@ -44,6 +45,15 @@ Once you have something that runs locally and passes tests you set up your remot
4445
git push -u origin dev-my-feature-branch
4546
```
4647

48+
You can then set draft public API documentation for people who would fetch this
49+
data from the API. Public API documentation is kept in the delphi-epidata
50+
repository, and there is a [template Markdown
51+
file](https://github.com/cmu-delphi/delphi-epidata/blob/main/docs/api/covidcast-signals/_source-template.md)
52+
that outlines the features that need to be documented. You can create a pull
53+
request to add a new file to `docs/api/covidcast-signals/` for your source. Our
54+
goal is to have public API documentation for the data at the same time as it
55+
becomes available to the public.
56+
4757
### Setting up for review and deployment
4858

4959
Once you have your branch set up you should get in touch with a platform engineer to pair up on the remaining production needs. These include:
@@ -55,7 +65,7 @@ Once you have your branch set up you should get in touch with a platform enginee
5565

5666
Once all the last mile configuration is in place you can create a pull request against the correct `deploy-*` branch to initiate the CI/CD pipeline which will build, test, and package your indicator for deployment.
5767

58-
If everything looks ok, platform engineering has validated the last mile, and the pull request is accepted, you can merge the PR. Deployment will start automatically.
68+
If everything looks ok, you've drafted source documentation, platform engineering has validated the last mile, and the pull request is accepted, you can merge the PR. Deployment will start automatically.
5969

6070
Hopefully it'll be a full on :tada:, after that :crossed_fingers:
6171

_delphi_utils_python/delphi_utils/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
from __future__ import absolute_import
66

7+
from .archive import ArchiveDiffer, GitArchiveDiffer, S3ArchiveDiffer
78
from .export import create_export_csv
89
from .utils import read_params
910

0 commit comments

Comments
 (0)