You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: README.md
+19-9Lines changed: 19 additions & 9 deletions
Original file line number
Diff line number
Diff line change
@@ -10,14 +10,15 @@ Each subdirectory contained here that is named after an indicator has specific d
10
10
11
11
**tl;dr**
12
12
13
-
- Create your new indicator branch from `main`.
14
-
- Build it using the appropriate template, following the guidelines in the included README.md and REVIEW.md files.
15
-
- Make some stuff!
16
-
- When your stuff works, push your `dev-*` branch to remote for review.
17
-
- Consult with a platform engineer for the remaining production setup needs. They will create a branch called `deploy-*` for your indicator.
18
-
- Initiate a pull request against this new branch.
19
-
- If your peers like it and Jenkins approves, deploy your changes by merging the PR.
20
-
- Rejoice!
13
+
1. Create your new indicator branch from `main`.
14
+
2. Build it using the appropriate template, following the guidelines in the included README.md and REVIEW.md files.
15
+
3. Make some stuff!
16
+
4. When your stuff works, push your `dev-*` branch to remote for review.
17
+
5. Consult with a platform engineer for the remaining production setup needs. They will create a branch called `deploy-*` for your indicator.
18
+
6. Initiate a pull request against this new branch.
19
+
7. Following [the source documentation template](https://github.com/cmu-delphi/delphi-epidata/blob/main/docs/api/covidcast-signals/_source-template.md), create public API documentation for the source. You can submit this as a pull request against the delphi-epidata repository.
20
+
8. If your peers like the code, the documentation is ready, and Jenkins approves, deploy your changes by merging the PR.
21
+
9. Rejoice!
21
22
22
23
### Starting out
23
24
@@ -44,6 +45,15 @@ Once you have something that runs locally and passes tests you set up your remot
44
45
git push -u origin dev-my-feature-branch
45
46
```
46
47
48
+
You can then set draft public API documentation for people who would fetch this
49
+
data from the API. Public API documentation is kept in the delphi-epidata
that outlines the features that need to be documented. You can create a pull
53
+
request to add a new file to `docs/api/covidcast-signals/` for your source. Our
54
+
goal is to have public API documentation for the data at the same time as it
55
+
becomes available to the public.
56
+
47
57
### Setting up for review and deployment
48
58
49
59
Once you have your branch set up you should get in touch with a platform engineer to pair up on the remaining production needs. These include:
@@ -55,7 +65,7 @@ Once you have your branch set up you should get in touch with a platform enginee
55
65
56
66
Once all the last mile configuration is in place you can create a pull request against the correct `deploy-*` branch to initiate the CI/CD pipeline which will build, test, and package your indicator for deployment.
57
67
58
-
If everything looks ok, platform engineering has validated the last mile, and the pull request is accepted, you can merge the PR. Deployment will start automatically.
68
+
If everything looks ok, you've drafted source documentation, platform engineering has validated the last mile, and the pull request is accepted, you can merge the PR. Deployment will start automatically.
59
69
60
70
Hopefully it'll be a full on :tada:, after that :crossed_fingers:
0 commit comments