Skip to content

Commit b183661

Browse files
committed
Remove smoothed version of cumulative signals
1 parent e9b90cd commit b183661

File tree

5 files changed

+9
-2
lines changed

5 files changed

+9
-2
lines changed

combo_cases_and_deaths/delphi_combo_cases_and_deaths/run.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,7 @@ def run_module(params):
322322
variants = [tuple((metric, geo_res)+sensor_signal(metric, sensor, smoother))
323323
for (metric, geo_res, sensor, smoother) in
324324
product(METRICS, GEO_RESOLUTIONS, SENSORS, SMOOTH_TYPES)]
325+
variants = [i for i in variants if "7dav" not in i[2] and "cumulative" not in i[2]]
325326
params = configure(variants, params)
326327
logger = get_structured_logger(
327328
__name__, filename=params["common"].get("log_filename"),

jhu/delphi_jhu/run.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ def run_module(params: Dict[str, Any]):
106106
for metric, geo_res, sensor, smoother in product(
107107
METRICS, GEO_RESOLUTIONS, SENSORS, SMOOTHERS
108108
):
109-
print(metric, geo_res, sensor, smoother)
109+
if "cumulative" in sensor and "seven_day_average" in smoother:
110+
continue
110111
logger.info(
111112
event="generating signal and exporting to CSV",
112113
metric=metric,

jhu/tests/test_run.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,8 @@ def test_output_files_exist(self, run_as_module):
3131
for date in dates:
3232
for geo in geos:
3333
for metric in metrics:
34+
if "7dav" in metric and "cumulative" in metric:
35+
continue
3436
# Can't compute 7dav for first few days of data because of NAs
3537
if date > "20200305" or "7dav" not in metric:
3638
expected_files += [date + "_" + geo + "_" + metric + ".csv"]

usafacts/delphi_usafacts/run.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,8 @@ def run_module(params: Dict[str, Dict[str, Any]]):
103103
dfs = {metric: pull_usafacts_data(base_url, metric, logger) for metric in METRICS}
104104
for metric, geo_res, sensor, smoother in product(
105105
METRICS, GEO_RESOLUTIONS, SENSORS, SMOOTHERS):
106+
if "cumulative" in sensor and "seven_day_average" in smoother:
107+
continue
106108
logger.info("generating signal and exporting to CSV",
107109
geo_res = geo_res,
108110
metric = metric,

usafacts/tests/test_run.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,8 +54,9 @@ def test_output_files_exist(self):
5454
for metric in metrics:
5555
if "7dav" in metric and date in dates[:6]:
5656
continue # there are no 7dav signals for first 6 days
57+
if "7dav" in metric and "cumulative" in metric:
58+
continue
5759
expected_files += [date + "_" + geo + "_" + metric + ".csv"]
58-
5960
assert set(csv_files) == set(expected_files)
6061

6162
def test_output_file_format(self):

0 commit comments

Comments
 (0)