add tests for remote source download vs local

Author: minhkhul

nssp/tests/test_patch.py

@@ -142,11 +142,59 @@ def test_get_patch_dates(self):
         for date in expected_dates:
             assert date in patch_dates
 
+    @mock_patch('delphi_nssp.patch.get_source_data')
+    @mock_patch('delphi_nssp.patch.run_module')
+    @mock_patch('delphi_nssp.patch.get_structured_logger')
+    @mock_patch('delphi_nssp.patch.read_params')
+    def test_patch_from_local_source(self, mock_read_params, mock_get_structured_logger, mock_run_module, mock_get_source_data):
+        mock_read_params.return_value = {
+            "common": {
+                "log_filename": "test.log",
+                "custom_run": True
+            },
+            "patch": {
+                "user": "user",
+                "start_issue": "2021-01-01",
+                "end_issue": "2021-01-16",
+                "patch_dir": "./patch_dir",
+                "source_dir": "./source_dir"
+            }
+        }
+        patch()
+
+        mock_get_source_data.assert_not_called()
+
+    @mock_patch('delphi_nssp.patch.get_source_data')
+    @mock_patch('delphi_nssp.patch.rmtree')
+    @mock_patch('delphi_nssp.patch.run_module')
+    @mock_patch('delphi_nssp.patch.get_structured_logger')
+    @mock_patch('delphi_nssp.patch.read_params')
+    def test_patch_download_remote_source(self, mock_read_params, mock_get_structured_logger, mock_run_module, mock_rmtree, mock_get_source_data):
+        mock_read_params.return_value = {
+            "common": {
+                "log_filename": "test.log",
+                "custom_run": True
+            },
+            "patch": {
+                "user": "user",
+                "start_issue": "2021-01-01",
+                "end_issue": "2021-01-16",
+                "patch_dir": "./patch_dir",
+                "source_dir": "./does_not_exist"
+            }
+        }
+        patch()
+        mock_get_source_data.assert_called_once()
+        assert mock_rmtree.call_count == 1
+        shutil.rmtree(mock_read_params.return_value["patch"]["patch_dir"])
+
+
 
+    @mock_patch('delphi_nssp.patch.get_source_data')
     @mock_patch('delphi_nssp.patch.run_module')
     @mock_patch('delphi_nssp.patch.get_structured_logger')
     @mock_patch('delphi_nssp.patch.read_params')
-    def test_patch_confirm_dir_structure_created(self, mock_read_params, mock_get_structured_logger, mock_run_module):
+    def test_patch_confirm_dir_structure_created(self, mock_read_params, mock_get_structured_logger, mock_run_module, mock_get_source_data):
         mock_read_params.return_value = {
             "common": {
                 "log_filename": "test.log",
@@ -180,7 +228,7 @@ def test_patch_confirm_dir_structure_created(self, mock_read_params, mock_get_st
 
     @mock_patch('delphi_nssp.patch.get_structured_logger')
     @mock_patch('delphi_nssp.patch.read_params')
-    def test_patch_confirm_values_generated(self, mock_read_params, mock_get_structured_logger):
+    def test_full_patch_code(self, mock_read_params, mock_get_structured_logger):
         mock_get_structured_logger.return_value.name = "delphi_nssp.patch"
         mock_read_params.return_value = {
             "common": {

nssp/tests/test_pull.py

@@ -45,8 +45,6 @@ def test_get_source_data(self):
         mock_sftp = MagicMock()
         mock_sftp.stat = MagicMock()
         mock_ssh.open_sftp.return_value = mock_sftp
-
-        # Mock the paramiko SSHClient
         with patch("paramiko.SSHClient", return_value=mock_ssh):
             get_source_data(params, logger)
 
@@ -55,7 +53,7 @@ def test_get_source_data(self):
         assert mock_sftp.get.call_count == 3
 
     @patch("delphi_nssp.pull.Socrata")
-    def test_pull_nssp_data(self, mock_socrata, caplog):
+    def test_normal_pull_nssp_data(self, mock_socrata, caplog):
         today = pd.Timestamp.today().strftime("%Y%m%d")
         backup_dir = 'test_raw_data_backups'