move training_end_date message to main

Author: nmdefries

backfill_corrections/delphiBackfillCorrection/R/main.R

@@ -262,6 +262,11 @@ main <- function(params) {
   params$training_start_date <- result$training_start_date
   params$training_end_date <- result$training_end_date
 
+  msg_ts(paste0(
+    str_interp("training_start_date is ${params$training_start_date}, "),
+    str_interp("training_end_date is ${params$training_end_date}")
+  ))
+
   # Loop over every indicator + signal combination.
   for (group_i in seq_len(nrow(INDICATORS_AND_SIGNALS))) {
     input_group <- INDICATORS_AND_SIGNALS[group_i,]

backfill_corrections/delphiBackfillCorrection/R/model.R

@@ -321,11 +321,6 @@ get_training_date_range <- function(params) {
   # referenced in cached file names, then those cached files will not be used.
   training_start_date <- training_end_date - params$training_days
 
-  msg_ts(paste0(
-    str_interp("training_start_date is ${training_start_date}, "),
-    str_interp("training_end_date is ${training_end_date}")
-  ))
-
   return(list(
     "training_start_date"=training_start_date,
     "training_end_date"=training_end_date

backfill_corrections/delphiBackfillCorrection/R/utils.R

@@ -214,5 +214,5 @@ make_key <- function(value_type, signal_suffix) {
 #' @template params-template
 #' @param key string indicating name of element within `params` to check
 params_element_exists_and_valid <- function(params, key) {
-  return(key %in% names(params) && !is.null(params[[key]]) && !is.na(params[[key]]) && params[[key]] != "")
+  return(key %in% names(params) && !is.null(params[[key]]) && !is.na(params[[key]]))
 }