re-set training_end_date and default test dates

Author: Jingjing Tang

backfill_corrections/delphiBackfillCorrection/R/constants.R

@@ -3,7 +3,7 @@ TAUS <- c(0.01, 0.025, 0.1, 0.25, 0.5, 0.75, 0.9, 0.975, 0.99)
 REF_LAG <- 60
 TEST_LAGS <- c(1:14, 21, 35, 51)
 TRAINING_DAYS <- 270
-TESTING_WINDOW <- 14
+TESTING_WINDOW <- 1
 LAG_WINDOW <- 5
 LAMBDA <- 0.1
 LAG_PAD <- 2

backfill_corrections/delphiBackfillCorrection/R/io.R

@@ -166,7 +166,7 @@ get_issue_date_range <- function(params) {
   # date t0 (t0 < TODAY), we will always need to train a new model based on
   # data t < t0.
   assert(
-    result$training_end_date < min(params$test_dates),
+    result$training_end_date <= min(params$test_dates),
     "training end date must be earlier than the earliest test date to produce valid predictions"
   )
 

backfill_corrections/delphiBackfillCorrection/R/model.R

@@ -286,7 +286,7 @@ generate_filename <- function(indicator, signal,
 #'
 #' @template params-template
 get_training_date_range <- function(params) {
-  default_end_date <- TODAY - params$testing_window - 1
+  default_end_date <- TODAY - params$testing_window + 1
 
   if (params$train_models) {
     if (params_element_exists_and_valid(params, "training_end_date")) {

backfill_corrections/delphiBackfillCorrection/R/utils.R

@@ -74,8 +74,8 @@ read_params <- function(path = "params.json", template_path = "params.json.templ
   if (!("ref_lag" %in% names(params))) {params$ref_lag <- REF_LAG}
   if (!("testing_window" %in% names(params))) {params$testing_window <- TESTING_WINDOW}
   if (!("test_dates" %in% names(params)) || length(params$test_dates) == 0) {
-    start_date <- TODAY - params$testing_window
-    end_date <- TODAY - 1
+    start_date <- TODAY - params$testing_window + 1
+    end_date <- TODAY
     params$test_dates <- seq(start_date, end_date, by="days")
   } else {
     if (length(params$test_dates) != 2) {