Skip to content

Commit 8bb9272

Browse files
committed
not all date_utils tests need metadata
1 parent dcc171d commit 8bb9272

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

google_symptoms/tests/test_date_utils.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,13 @@
44
from freezegun import freeze_time
55
from conftest import TEST_DIR, NEW_DATE
66

7+
import covidcast
8+
79
from delphi_utils.validator.utils import lag_converter
810
from delphi_google_symptoms.constants import FULL_BKFILL_START_DATE
911
from delphi_google_symptoms.date_utils import generate_query_dates, generate_num_export_days, generate_patch_dates
12+
13+
1014
class TestDateUtils:
1115

1216
@freeze_time("2021-01-05")
@@ -36,31 +40,29 @@ def test_generate_query_dates_custom(self):
3640
assert set(output) == set(expected)
3741

3842
def test_generate_export_dates(self, params, logger, monkeypatch):
39-
import covidcast
4043
metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata.csv")
4144
monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
42-
num_export_days = generate_num_export_days(params, logger)
4345

46+
num_export_days = generate_num_export_days(params, logger)
4447
expected_num_export_days = params["indicator"]["num_export_days"]
45-
4648
assert num_export_days == expected_num_export_days
4749

4850
def test_generate_export_dates_normal(self, params_w_no_date, logger, monkeypatch):
49-
import covidcast
5051
metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata.csv")
5152
monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
53+
5254
num_export_days = generate_num_export_days(params_w_no_date, logger)
5355

54-
max_expected_lag = lag_converter(params_w_no_date["validation"]["common"].get("max_expected_lag", {"all": 4}))
56+
max_expected_lag = lag_converter(params_w_no_date["validation"]["common"]["max_expected_lag"])
5557
global_max_expected_lag = max(list(max_expected_lag.values()))
56-
expected_num_export_days = params_w_no_date["validation"]["common"].get("span_length", 14) + global_max_expected_lag
58+
expected_num_export_days = params_w_no_date["validation"]["common"]["span_length"] + global_max_expected_lag
5759

5860
assert num_export_days == expected_num_export_days
5961

6062
def test_generate_export_date_missing(self, params_w_no_date, logger, monkeypatch):
61-
import covidcast
6263
metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata_missing.csv")
6364
monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
65+
6466
num_export_days = generate_num_export_days(params_w_no_date, logger)
6567
expected_num_export_days = (date.today() - FULL_BKFILL_START_DATE.date()).days + 1
6668
assert num_export_days == expected_num_export_days
@@ -89,10 +91,7 @@ def generate_expected_start_end_dates(self, params_, issue_date):
8991
"export_end_date": max(dates[6:21])
9092
}
9193

92-
def test_generate_patch_dates(self, params_w_patch, logger, monkeypatch):
93-
import covidcast
94-
metadata_df = pd.read_csv(f"{TEST_DIR}/test_data/covid_metadata_missing.csv")
95-
monkeypatch.setattr(covidcast, "metadata", lambda: metadata_df)
94+
def test_generate_patch_dates(self, params_w_patch, logger):
9695
max_expected_lag = lag_converter(params_w_patch["validation"]["common"]["max_expected_lag"])
9796
global_max_expected_lag = max(list(max_expected_lag.values()))
9897
num_export_days = params_w_patch["validation"]["common"]["span_length"]

0 commit comments

Comments
 (0)