Skip to content

Commit 7ef2f5b

Browse files
authored
Merge pull request #1827 from cmu-delphi/ndefries/backfill/mem-log-make-cleanup
[Backfill corrections] Allocate enough shared memory for parallel prediction generation
2 parents 87a18d7 + b55abe8 commit 7ef2f5b

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

backfill_corrections/Makefile

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,8 @@ run-local: setup-dirs
6767
grep "backfill correction completed successfully" $(LOG_FILE)
6868
grep "scheduled core" $(LOG_FILE) ; \
6969
[ "$$?" -eq 1 ]
70+
grep "SIGBUS" $(LOG_FILE) ; \
71+
[ "$$?" -eq 1 ]
7072

7173
gurobi.lic:
7274
@echo WLSACCESSID=$(GRB_WLSACCESSID) >> $(GRB_LICENSE_FILE)
@@ -81,6 +83,7 @@ run:
8183
-v "`realpath $(USR_CACHE_DIR)`:/backfill_corrections/${CACHE_DIR}" \
8284
-v "${PWD}"/params.json:/backfill_corrections/params.host.json \
8385
--env GRB_LICENSE_FILE=$(GRB_LICENSE_FILE) \
86+
--shm-size=2gb \
8487
-it "${DOCKER_IMAGE}:${DOCKER_TAG}" \
8588
/bin/bash -c "cp params.host.json params.json && make gurobi.lic && make standardize-dirs && make run-local OPTIONS=\"${OPTIONS}\" LOG_FILE=${LOG_FILE}"
8689

@@ -124,7 +127,7 @@ standardize-dirs:
124127
$(PYTHON) -m delphi_utils set export_dir $(EXPORT_DIR)
125128

126129
clean:
127-
rm -f $(USR_EXPORT_DIR)/*.csv.gz
130+
rm -rf $(USR_EXPORT_DIR)/*
128131

129132
coverage:
130133
Rscript -e 'covr::package_coverage("delphiBackfillCorrection")'

backfill_corrections/delphiBackfillCorrection/R/main.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ run_backfill <- function(df, params,
6060
msg_ts("Splitting data into geo groups")
6161
group_dfs <- group_split(df, geo_value)
6262

63+
msg_ts("Beginning training and/or testing...")
6364
# Build model for each location
6465
apply_fn <- ifelse(params$parallel, mclapply, lapply)
6566
result <- apply_fn(group_dfs, function(subdf) {

0 commit comments

Comments
 (0)