Improve linting

Author: rumackaaron

changehc/delphi_changehc/config.py

@@ -6,7 +6,6 @@
 """
 
 from datetime import datetime, timedelta
-import numpy as np
 
 
 class Config:

changehc/delphi_changehc/download_ftp_files.py

@@ -4,7 +4,6 @@
 # standard
 import datetime
 import functools
-import sys
 from os import path
 
 # third party
@@ -68,7 +67,7 @@ def download(out_path, ftp_conn):
 
         sftp.chdir('/dailycounts/Covid_Outpatients_By_County')
         get_files_from_dir(sftp, out_path)
-    
+
     finally:
         if client:
             client.close()

changehc/delphi_changehc/run.py

@@ -34,7 +34,7 @@ def run_module():
     # the filenames are expected to be in the format:
     # Denominator: "YYYYMMDD_All_Outpatients_By_County.dat.gz"
     # Numerator: "YYYYMMDD_Covid_Outpatients_By_County.dat.gz"
-    
+
     if params["drop_date"] is None:
         dropdate_denom = datetime.strptime(
             Path(params["input_denom_file"]).name.split("_")[0], "%Y%m%d"

changehc/delphi_changehc/sensor.py

@@ -129,7 +129,7 @@ def fit(y_data, first_sensor_date, geo_id, num_col="num", den_col="den"):
 
         # checks - due to the smoother, the first value will be NA
         assert (
-                np.sum(np.isnan(smoothed_total_rates[1:]) == True) == 0
+                np.sum(np.isnan(smoothed_total_rates[1:])) == 0
         ), "NAs in rate calculation"
         assert (
                 np.sum(smoothed_total_rates[1:] <= 0) == 0

changehc/delphi_changehc/update_sensor.py

@@ -5,7 +5,6 @@
 """
 # standard packages
 import logging
-from datetime import timedelta
 from multiprocessing import Pool, cpu_count
 import covidcast
 from delphi_utils import GeoMapper, S3ArchiveDiffer, read_params
@@ -18,7 +17,7 @@
 from .load_data import load_combined_data
 from .sensor import CHCSensor
 from .weekday import Weekday
-from .constants import SIGNALS, SMOOTHED, SMOOTHED_ADJ, HRR, NA, FIPS
+from .constants import SIGNALS, SMOOTHED, SMOOTHED_ADJ, NA
 
 
 def write_to_csv(output_dict, write_se, out_name, output_path="."):
@@ -123,6 +122,8 @@ def public_signal(signal_):
 
 
 class CHCSensorUpdator:
+    """Contains methods to update sensor and write results to csv
+    """
 
     def __init__(self,
                  startdate,
@@ -181,10 +182,10 @@ def geo_reindex(self, data):
         # get right geography
         geo = self.geo
         gmpr = GeoMapper()
-        if geo not in {"county", "state", "msa", "hrr"}: 
+        if geo not in {"county", "state", "msa", "hrr"}:
             logging.error(f"{geo} is invalid, pick one of 'county', 'state', 'msa', 'hrr'")
             return False
-        elif geo == "county":
+        if geo == "county":
             data_frame = gmpr.fips_to_megacounty(data,Config.MIN_DEN,Config.MAX_BACKFILL_WINDOW,thr_col="den",mega_col=geo)
         elif geo == "state":
             data_frame = gmpr.replace_geocode(data, "fips", "state_id", new_col="state")
@@ -305,4 +306,3 @@ def update_sensor(self,
         for exported_file in fails:
             print(f"Failed to archive '{exported_file}'")
         '''
-        return