Skip to content

Commit 2976588

Browse files
committed
resolve TODOs
1 parent 78b9d85 commit 2976588

File tree

1 file changed

+0
-5
lines changed
  • backfill_corrections/delphiBackfillCorrection/R

1 file changed

+0
-5
lines changed

backfill_corrections/delphiBackfillCorrection/R/model.R

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -208,22 +208,17 @@ get_model <- function(model_path, train_data, covariates, tau,
208208
" does not exist; training new model")
209209
}
210210
# Quantile regression
211-
## TODO: how does the speed compare using GLPK? Apparently it's faster on smaller
212-
# models.
213211
obj <- quantile_lasso(as.matrix(train_data[covariates]),
214212
train_data$log_value_target, tau = tau,
215213
lambda = lambda, standardize = FALSE, lp_solver = lp_solver)
216214

217215
# Save model to cache.
218216
create_dir_not_exist(dirname(model_path))
219-
## TODO: save() is fairly slow. Since we're not sharing the model files, can we
220-
# use saveRDS() instead?
221217
save(obj, file=model_path)
222218
} else {
223219
# Load model from cache invisibly. Object has the same name as the original
224220
# model object, `obj`.
225221
msg_ts("Loading from ", model_path)
226-
## TODO: readRDS()
227222
load(model_path)
228223
}
229224

0 commit comments

Comments
 (0)