Merge pull request #1833 from cmu-delphi/release/indicators_v0.3.37_utils_v0.3.14

Release covidcast-indicators 0.3.37

Author: krivard

.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.3.36
+current_version = 0.3.37
 commit = True
 message = chore: bump covidcast-indicators to {new_version}
 tag = False

_delphi_utils_python/.bumpversion.cfg

@@ -1,5 +1,5 @@
 [bumpversion]
-current_version = 0.3.13
+current_version = 0.3.14
 commit = True
 message = chore: bump delphi_utils to {new_version}
 tag = False

_delphi_utils_python/delphi_utils/__init__.py

@@ -15,4 +15,4 @@
 from .nancodes import Nans
 from .weekday import Weekday
 
-__version__ = "0.3.13"
+__version__ = "0.3.14"

_delphi_utils_python/delphi_utils/validator/dynamic.py

@@ -404,7 +404,7 @@ def check_max_date_vs_reference(self, df_to_test, df_to_reference, checking_date
         Returns:
             - None
         """
-        if df_to_test["time_value"].max() < df_to_reference["time_value"].max():
+        if df_to_test["time_value"].max() < df_to_reference["time_value"].max().date():
             report.add_raised_error(
                 ValidationFailure("check_max_date_vs_reference",
                                   checking_date,

_delphi_utils_python/setup.py

@@ -26,7 +26,7 @@
 
 setup(
     name="delphi_utils",
-    version="0.3.13",
+    version="0.3.14",
     description="Shared Utility Functions for Indicators",
     long_description=long_description,
     long_description_content_type="text/markdown",

_delphi_utils_python/tests/validator/test_dynamic.py

@@ -1,5 +1,5 @@
 """Tests for dynamic validator."""
-from datetime import date, datetime
+from datetime import date, datetime, timedelta
 import numpy as np
 import pandas as pd
 
@@ -465,3 +465,32 @@ def test_source_api_overlap(self):
 
         assert len(report.raised_warnings) == 2
         assert report.raised_warnings[0].check_name == "check_positive_negative_spikes"
+
+class TestDateComparison:
+    params = {
+        "common": {
+            "data_source": "",
+            "span_length": 1,
+            "end_date": "2020-09-02"
+        }
+    }
+
+    def test_date_comparison_by_type(self):
+        validator = DynamicValidator(self.params)
+        report = ValidationReport([])
+
+        ref_val = [30, 30, 30]
+        test_val = [100, 100, 100]
+
+        START = datetime.strptime("2020-10-01", "%Y-%m-%d")
+        ref_data = pd.DataFrame({"val": ref_val, "se": [np.nan] * len(ref_val),
+                    "sample_size": [np.nan] * len(ref_val), "geo_id": ["1"] * len(ref_val),
+                    # datetime64 type
+                    "time_value": pd.date_range(start=START, end=START + timedelta(days=len(ref_val) - 1))})
+        test_data = pd.DataFrame({"val": test_val, "se": [np.nan] * len(test_val),
+                     "sample_size": [np.nan] * len(test_val), "geo_id": ["1"] * len(test_val),
+                     # datetime.date type
+                     "time_value": datetime.strptime("2020-10-26", "%Y-%m-%d").date()})
+
+        # This should run without raising any errors.
+        validator.check_max_date_vs_reference(test_data, ref_data, "date", "state", "signal", report)

changehc/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

claims_hosp/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

doctor_visits/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

dsew_community_profile/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

google_symptoms/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

hhs_hosp/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

nchs_mortality/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

nowcast/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

quidel_covidtest/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37

sir_complainsalot/version.cfg

@@ -1 +1 @@
-current_version = 0.3.36
+current_version = 0.3.37