Skip to content

Commit 234c600

Browse files
authored
Merge pull request #1458 from cmu-delphi/krivard/patch-validator
Patch validator for chng subdivision mapping change
2 parents 27b9ad5 + 7c0a91e commit 234c600

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

_delphi_utils_python/delphi_utils/validator/datafetcher.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,10 @@ def get_geo_signal_combos(data_source):
111111
Cross references based on combinations reported available by COVIDcast metadata.
112112
"""
113113
# Maps data_source name with what's in the API, lists used in case of multiple names
114+
# pylint: disable=fixme
115+
# TODO: Extract this mapping from meta response instead of hard-coding
116+
# https://github.com/cmu-delphi/covidcast-indicators/issues/1457
114117
source_signal_mappings = {
115-
'chng': ['chng-cli', 'chng-covid'],
116118
'indicator-combination': ['indicator-combination-cases-deaths'],
117119
'quidel': ['quidel-covid-ag'],
118120
'safegraph': ['safegraph-weekly']

_delphi_utils_python/tests/validator/test_datafetcher.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ def test_make_date_filter(self):
2121
assert not date_filter(FILENAME_REGEX.match("20200620_a_b.csv"))
2222
assert not date_filter(FILENAME_REGEX.match("202006_a_b.csv"))
2323

24+
# pylint: disable=fixme
25+
# TODO: mock out the advanced meta endpoint /covidcast/meta as well
26+
# https://github.com/cmu-delphi/covidcast-indicators/issues/1456
2427
@mock.patch("covidcast.metadata")
2528
def test_get_geo_signal_combos(self, mock_metadata):
2629
"""Test that the geo signal combos are correctly pulled from the covidcast metadata."""

0 commit comments

Comments
 (0)