Skip to content

Commit 049de70

Browse files
authored
issue date must be 8 digits for patching (#2100)
* issue date must be 8 digits * fixed test * suggested changes
1 parent 51edb05 commit 049de70

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

nhsn/delphi_nhsn/patch.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,12 @@ def patch(params):
7878

7979
patch_list = filter_source_files(source_files)
8080
for file in patch_list:
81-
issue_date = datetime.strptime(file.name.split(".")[0], "%Y%m%d")
82-
current_issue_ew = Week.fromdate(issue_date)
83-
logger.info("Running issue", issue_date=issue_date.strftime("%Y-%m-%d"))
84-
params["patch"]["issue_date"] = issue_date.strftime("%Y%m%d")
85-
current_issue_dir = f"{params['patch']['patch_dir']}/issue_{current_issue_ew}/nhsn"
81+
issue_date_str = file.name.split(".")[0]
82+
logger.info("Running issue", issue_date=datetime.strptime(issue_date_str, "%Y%m%d").strftime("%Y-%m-%d"))
83+
params["patch"]["issue_date"] = issue_date_str
84+
# regardless of week date type or not the directory name must be issue_date_YYYYMMDD
85+
# conversion in done in acquisition
86+
current_issue_dir = f"{params['patch']['patch_dir']}/issue_{issue_date_str}/nhsn"
8687
makedirs(current_issue_dir, exist_ok=True)
8788
params["common"]["export_dir"] = current_issue_dir
8889
params["common"]["custom_run"] = True

nhsn/tests/test_patch.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,7 @@ def test_patch(self, params_w_patch):
112112
issue_dt_str = issue_path.name.replace("issue_", "")
113113
for file in Path(issue_path / "nhsn").iterdir():
114114
df = pd.read_csv(file)
115-
val = Week.fromdate(datetime.strptime(str(int(df["val"][0])), "%Y%m%d"))
116-
assert issue_dt_str == str(val)
115+
assert issue_dt_str == str(int(df["val"][0]))
117116

118117
# clean up
119118
shutil.rmtree(f"{TEST_DIR}/patch_dir")

0 commit comments

Comments
 (0)