Merge pull request #540 from cmu-delphi/quidel-pylint

Set pylint equal to others

Author: krivard

quidel_covidtest/.pylintrc

@@ -20,4 +20,3 @@ attr-rgx=[a-z_][a-z0-9_]*
 
 # Don't complain about pytest "unused" arguments.
 ignored-argument-names=(_.*|run_as_module)
-disable=R0801, C0330, E1101, E0611, C0114, C0116, C0103, R0913, R0914, W0702, W0212, E1136

quidel_covidtest/delphi_quidel_covidtest/geo_maps.py

@@ -1,45 +1,51 @@
 """Contains geographic mapping tools."""
 from delphi_utils import GeoMapper
 
-date_col = "timestamp"
-data_cols = ['totalTest', 'numUniqueDevices', 'positiveTest', "population"]
-gmpr = GeoMapper() # Use geo utils
+DATE_COL = "timestamp"
+DATA_COLS = ['totalTest', 'numUniqueDevices', 'positiveTest', "population"]
+GMPR = GeoMapper()  # Use geo utils
 GEO_KEY_DICT = {
         "county": "fips",
         "msa": "msa",
         "hrr": "hrr",
         "state": "state_id"
 }
+
+
 def geo_map(geo_res, df):
+    """
+    Map a geocode to a new value.
+    """
     data = df.copy()
     geo_key = GEO_KEY_DICT[geo_res]
     # Add population for each zipcode
-    data = gmpr.add_population_column(data, "zip")
+    data = GMPR.add_population_column(data, "zip")
     # zip -> geo_res
-    data = gmpr.replace_geocode(data, "zip", geo_key,
-                                date_col=date_col, data_cols=data_cols)
+    data = GMPR.replace_geocode(data, "zip", geo_key,
+                                date_col=DATE_COL, data_cols=DATA_COLS)
     if geo_res == "state":
         return data
     # Add parent state
     data = add_parent_state(data, geo_res, geo_key)
     return data, geo_key
 
+
 def add_parent_state(data, geo_res, geo_key):
     """
     - map from msa/hrr to state, going by the state with the largest
       population (since a msa/hrr may span multiple states)
     - map from county to the corresponding state
     """
-    fips_to_state = gmpr._load_crosswalk(from_code="fips", to_code="state")
+    fips_to_state = GMPR._load_crosswalk(from_code="fips", to_code="state")  # pylint: disable=protected-access
     if geo_res == "county":
-        mix_map = fips_to_state[["fips", "state_id"]]
+        mix_map = fips_to_state[["fips", "state_id"]]  # pylint: disable=unsubscriptable-object
     else:
-        fips_to_geo_res = gmpr._load_crosswalk(from_code="fips", to_code=geo_res)
+        fips_to_geo_res = GMPR._load_crosswalk(from_code="fips", to_code=geo_res)  # pylint: disable=protected-access
         mix_map = fips_to_geo_res[["fips", geo_res]].merge(
-                fips_to_state[["fips", "state_id"]],
+                fips_to_state[["fips", "state_id"]],  # pylint: disable=unsubscriptable-object
                 on="fips",
                 how="inner")
-        mix_map = gmpr.add_population_column(mix_map, "fips").groupby(
+        mix_map = GMPR.add_population_column(mix_map, "fips").groupby(
                 geo_res).max().reset_index().drop(
                 ["fips", "population"], axis = 1)
     # Merge the info of parent state to the data