Return non-zero exit code if library install fails due to dependency resolution (arduino#728)

hdiniz · web-flow · commit e4d4651df7d6 · 2020-05-28T10:36:44.000+02:00
diff --git a/cli/lib/install.go b/cli/lib/install.go
@@ -72,6 +72,7 @@ func runInstallCommand(cmd *cobra.Command, args []string) {
 			})
 			if err != nil {
 				feedback.Errorf("Error resolving dependencies for %s: %s", libRef, err)
+				os.Exit(errorcodes.ErrGeneric)
 			}
 			for _, dep := range depsResp.GetDependencies() {
 				feedback.Printf("%s depends on %s@%s", libRef, dep.GetName(), dep.GetVersionRequired())

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,7 @@ func runInstallCommand(cmd *cobra.Command, args []string) {`
`72`	`72`	`})`
`73`	`73`	`if err != nil {`
`74`	`74`	`feedback.Errorf("Error resolving dependencies for %s: %s", libRef, err)`
	`75`	`+ os.Exit(errorcodes.ErrGeneric)`
`75`	`76`	`}`
`76`	`77`	`for _, dep := range depsResp.GetDependencies() {`
`77`	`78`	`feedback.Printf("%s depends on %s@%s", libRef, dep.GetName(), dep.GetVersionRequired())`