Skip to content

Commit e26ac36

Browse files
committed
Added comments and TODOs
1 parent dba1f01 commit e26ac36

File tree

1 file changed

+9
-0
lines changed

1 file changed

+9
-0
lines changed

internal/arduino/builder/libraries.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,14 +161,23 @@ func (b *Builder) compileLibrary(library *libraries.Library, includes []string)
161161
b.logger.Info(i18n.Tr(`Compiling library "%[1]s"`, library.Name))
162162
}
163163

164+
// TODO: libraries with "dot_a_linkage=true" or libraries already providing a
165+
// precompiled lib.a needs extra boilerplate to be handled. At the moment
166+
// they are not handled correctly.
167+
164168
var targetArchivedLibrary *paths.Path
165169
if b.librariesBuildCachePath != nil {
166170
archivedLibName := getCachedLibraryArchiveDirName(
167171
b.buildProperties.Get("build.fqbn"),
168172
b.buildProperties.Get("compiler.optimization_flags"),
173+
// TODO: Add included library set here
169174
library.InstallDir,
170175
)
171176

177+
// TODO: if a single library needs a rebuild then all libraries requires a rebuild.
178+
// This means that the `canUseArchivedLib` must be checked for all libraries
179+
// in advance in the `compileLibraries` method.
180+
172181
canUseArchivedLib := func(archivedLib *paths.Path) bool {
173182
if b.onlyUpdateCompilationDatabase || b.clean {
174183
return false

0 commit comments

Comments
 (0)