Added test for regression

See arduino#1817 (review)

Author: cmaglie

Diff for: internal/integrationtest/arduino-cli.go

@@ -352,3 +352,15 @@ func (inst *ArduinoCLIInstance) LibraryInstall(ctx context.Context, name, versio
 	logCallf(">>> LibraryInstall(%+v)\n", req)
 	return installCl, err
 }
+
+// LibraryUninstall calls the "LibraryUninstall" gRPC method.
+func (inst *ArduinoCLIInstance) LibraryUninstall(ctx context.Context, name, version string) (commands.ArduinoCoreService_LibraryUninstallClient, error) {
+	req := &commands.LibraryUninstallRequest{
+		Instance: inst.instance,
+		Name:     name,
+		Version:  version,
+	}
+	installCl, err := inst.cli.daemonClient.LibraryUninstall(ctx, req)
+	logCallf(">>> LibraryUninstall(%+v)\n", req)
+	return installCl, err
+}

Diff for: internal/integrationtest/daemon/daemon_lib_install_test.go

@@ -79,12 +79,16 @@ func TestDaemonBundleLibInstall(t *testing.T) {
 	}
 
 	// Check if libraries are installed as expected
+	installedEthernetVersion := ""
 	{
 		resp, err := grpcInst.LibraryList(context.Background(), "", "", true, false)
 		require.NoError(t, err)
 		libsAndLocation := map[string]commands.LibraryLocation{}
 		for _, lib := range resp.GetInstalledLibraries() {
 			libsAndLocation[lib.Library.Name] = lib.Library.Location
+			if lib.Library.Name == "Ethernet" {
+				installedEthernetVersion = lib.Library.Version
+			}
 		}
 		require.Contains(t, libsAndLocation, "Ethernet")
 		require.Contains(t, libsAndLocation, "SD")
@@ -94,6 +98,36 @@ func TestDaemonBundleLibInstall(t *testing.T) {
 		require.Equal(t, libsAndLocation["Firmata"], commands.LibraryLocation_LIBRARY_LOCATION_BUILTIN)
 	}
 
+	// Remove library from sketchbook
+	{
+		uninstCl, err := grpcInst.LibraryUninstall(context.Background(), "Ethernet", installedEthernetVersion)
+		require.NoError(t, err)
+		for {
+			msg, err := uninstCl.Recv()
+			if err == io.EOF {
+				break
+			}
+			require.NoError(t, err)
+			fmt.Printf("LIB INSTALL> %+v\n", msg)
+		}
+	}
+
+	// Check if libraries are installed as expected
+	{
+		resp, err := grpcInst.LibraryList(context.Background(), "", "", true, false)
+		require.NoError(t, err)
+		libsAndLocation := map[string]commands.LibraryLocation{}
+		for _, lib := range resp.GetInstalledLibraries() {
+			libsAndLocation[lib.Library.Name] = lib.Library.Location
+		}
+		require.Contains(t, libsAndLocation, "Ethernet")
+		require.Contains(t, libsAndLocation, "SD")
+		require.Contains(t, libsAndLocation, "Firmata")
+		require.Equal(t, libsAndLocation["Ethernet"], commands.LibraryLocation_LIBRARY_LOCATION_BUILTIN)
+		require.Equal(t, libsAndLocation["SD"], commands.LibraryLocation_LIBRARY_LOCATION_BUILTIN)
+		require.Equal(t, libsAndLocation["Firmata"], commands.LibraryLocation_LIBRARY_LOCATION_BUILTIN)
+	}
+
 	// Un-Set builtin libraries dir
 	err := cli.SetValue("directories.builtin.libraries", `""`)
 	require.NoError(t, err)