testsuite: added test for arduino#1614

Author: cmaglie

Diff for: internal/integrationtest/arduino-cli.go

@@ -259,3 +259,26 @@ func (inst *ArduinoCLIInstance) BoardListWatch() (commands.ArduinoCoreService_Bo
 	}
 	return watcher, watcher.Send(boardListWatchReq)
 }
+
+// PlatformInstall calls the "PlatformInstall" gRPC method.
+func (inst *ArduinoCLIInstance) PlatformInstall(ctx context.Context, packager, arch, version string) (commands.ArduinoCoreService_PlatformInstallClient, error) {
+	installCl, err := inst.cli.daemonClient.PlatformInstall(ctx, &commands.PlatformInstallRequest{
+		Instance:        inst.instance,
+		PlatformPackage: packager,
+		Architecture:    arch,
+		Version:         version,
+	})
+	logCallf(">>> PlatformInstall(%v:%v %v)\n", packager, arch, version)
+	return installCl, err
+}
+
+func (inst *ArduinoCLIInstance) Compile(ctx context.Context, fqbn, sketchPath string) (commands.ArduinoCoreService_CompileClient, error) {
+	compileCl, err := inst.cli.daemonClient.Compile(ctx, &commands.CompileRequest{
+		Instance:   inst.instance,
+		Fqbn:       fqbn,
+		SketchPath: sketchPath,
+		Verbose:    true,
+	})
+	logCallf(">>> Compile(%v %v)\n", fqbn, sketchPath)
+	return compileCl, err
+}

Diff for: internal/integrationtest/daemon/daemon_compile_test.go

@@ -0,0 +1,98 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2022 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to [email protected].
+
+package daemon_test
+
+import (
+	"context"
+	"fmt"
+	"io"
+	"testing"
+
+	"github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
+	"github.com/arduino/go-paths-helper"
+	"github.com/stretchr/testify/require"
+)
+
+func TestDaemonCompileOptions(t *testing.T) {
+	env, cli := createEnvForDaemon(t)
+	defer env.CleanUp()
+
+	inst := cli.Create()
+	require.NoError(t, inst.Init("", "", func(ir *commands.InitResponse) {
+		fmt.Printf("INIT> %v\n", ir.GetMessage())
+	}))
+
+	plInst, err := inst.PlatformInstall(context.Background(), "arduino", "avr", "1.8.5")
+	require.NoError(t, err)
+	for {
+		msg, err := plInst.Recv()
+		if err == io.EOF {
+			break
+		}
+		require.NoError(t, err)
+		fmt.Printf("INSTALL> %v\n", msg)
+	}
+
+	// Install boards.local.txt to trigger bug
+	platformLocalTxt := paths.New("testdata", "boards.local.txt-issue1614")
+	err = platformLocalTxt.CopyTo(cli.DataDir().
+		Join("packages", "arduino", "hardware", "avr", "1.8.5", "boards.local.txt"))
+	require.NoError(t, err)
+
+	// Re-init instance to update changes
+	require.NoError(t, inst.Init("", "", func(ir *commands.InitResponse) {
+		fmt.Printf("INIT> %v\n", ir.GetMessage())
+	}))
+
+	// Build sketch (with errors)
+	sk := paths.New("testdata", "bare_minimum")
+	compile, err := inst.Compile(context.Background(), "arduino:avr:uno:some_menu=bad", sk.String())
+	require.NoError(t, err)
+	for {
+		msg, err := compile.Recv()
+		if err == io.EOF {
+			require.FailNow(t, "Expected compilation failure", "compilation succeeded")
+			break
+		}
+		if err != nil {
+			fmt.Println("COMPILE ERROR>", err)
+			break
+		}
+		// if msg.OutStream != nil {
+		// 	fmt.Printf("COMPILE> %v\n", string(msg.GetOutStream()))
+		// }
+		if msg.ErrStream != nil {
+			fmt.Printf("COMPILE> %v\n", string(msg.GetErrStream()))
+		}
+	}
+
+	// Build sketch (without errors)
+	compile, err = inst.Compile(context.Background(), "arduino:avr:uno:some_menu=good", sk.String())
+	require.NoError(t, err)
+	for {
+		msg, err := compile.Recv()
+		if err == io.EOF {
+			break
+		}
+		require.NoError(t, err)
+		// if msg.OutStream != nil {
+		// 	fmt.Printf("COMPILE> %v\n", string(msg.GetOutStream()))
+		// }
+		if msg.ErrStream != nil {
+			fmt.Printf("COMPILE> %v\n", string(msg.GetErrStream()))
+		}
+	}
+}

Diff for: internal/integrationtest/daemon/testdata/bare_minimum/bare_minimum.ino

@@ -0,0 +1,2 @@
+void setup() {}
+void loop() {}

Diff for: internal/integrationtest/daemon/testdata/boards.local.txt-issue1614

@@ -0,0 +1,10 @@
+# https://github.com/arduino/arduino-cli/issues/1614
+
+menu.some_menu=Some Custom Menu
+
+uno.menu.some_menu.bad=Bad Option
+uno.menu.some_menu.bad.build.extra_flags=-bad-build-extraflags
+uno.menu.some_menu.bad.compiler.cpp.extra_flags=-bad-compiler-cpp-extraflags
+
+uno.menu.some_menu.good=Good Option
+uno.menu.some_menu.good.compiler.cpp.extra_flags=-DGOOD_COMPILER_CPP_EXTRA_FLAGS