Skip to content

Commit 406df06

Browse files
committed
Print a friendly message if a tool is not available
See arduino#755
1 parent bf4042e commit 406df06

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

Diff for: commands/debug/debug.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,11 @@ func getCommandLine(req *dbg.DebugConfigReq, pm *packagemanager.PackageManager)
185185
if requiredTools, err := pm.FindToolsRequiredForBoard(board); err == nil {
186186
for _, requiredTool := range requiredTools {
187187
logrus.WithField("tool", requiredTool).Info("Tool required for debug")
188-
toolProperties.Merge(requiredTool.RuntimeProperties())
188+
if requiredTool.IsInstalled() {
189+
toolProperties.Merge(requiredTool.RuntimeProperties())
190+
} else {
191+
errStream.Write([]byte(fmt.Sprintf("Warning: tool '%s' is not installed. It might not be available for your OS.", requiredTool)))
192+
}
189193
}
190194
}
191195

Diff for: commands/upload/upload.go

+5-1
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,11 @@ func runProgramAction(pm *packagemanager.PackageManager,
193193
if requiredTools, err := pm.FindToolsRequiredForBoard(board); err == nil {
194194
for _, requiredTool := range requiredTools {
195195
logrus.WithField("tool", requiredTool).Info("Tool required for upload")
196-
uploadProperties.Merge(requiredTool.RuntimeProperties())
196+
if requiredTool.IsInstalled() {
197+
uploadProperties.Merge(requiredTool.RuntimeProperties())
198+
} else {
199+
errStream.Write([]byte(fmt.Sprintf("Warning: tool '%s' is not installed. It might not be available for your OS.", requiredTool)))
200+
}
197201
}
198202
}
199203

0 commit comments

Comments
 (0)