Only report warning if proxy settings are bogus

facchinm · cmaglie · commit 371681668a84 · 2019-01-09T13:06:50.000+01:00
diff --git a/configs/preferences_txt_serializer.go b/configs/preferences_txt_serializer.go
@@ -88,8 +88,7 @@ func (config *Configuration) LoadFromDesktopIDEPreferences() error {
 	}
 	err = config.proxyConfigsFromIDEPrefs(props)
 	if err != nil {
-		logrus.WithError(err).Warn("Error during unserialize from IDE preferences")
-		return err
+		logrus.WithError(err).Warn("Error loading proxy settings from IDE preferences")
 	}
 	if dir, has := props.GetOk("sketchbook.path"); has {
 		config.SketchbookDir = paths.New(dir)

Original file line number	Diff line number	Diff line change
`@@ -88,8 +88,7 @@ func (config *Configuration) LoadFromDesktopIDEPreferences() error {`
`88`	`88`	`}`
`89`	`89`	`err = config.proxyConfigsFromIDEPrefs(props)`
`90`	`90`	`if err != nil {`
`91`		`- logrus.WithError(err).Warn("Error during unserialize from IDE preferences")`
`92`		`- return err`
	`91`	`+ logrus.WithError(err).Warn("Error loading proxy settings from IDE preferences")`
`93`	`92`	`}`
`94`	`93`	`if dir, has := props.GetOk("sketchbook.path"); has {`
`95`	`94`	`config.SketchbookDir = paths.New(dir)`