feat(aspnetcore-engine): fixes for delaying platform destruction

With this change we replace the aspnet-engine to use the common engine to fix a number of problems.

1) Injector has already been destroyed. Error: Injector has already been destroyed.
2) Mismatching HTML snapshots.

This does come with a drawback, that we needed to remove `moduleRef` from the `IEngineRenderResult` this however shouldn't cause any problem since this couldn't be used because the platform would have already been destroyed.

Fixes angular#1808
Fixes angular#1404

Author: alan-agius4

modules/aspnetcore-engine/package.json

@@ -20,6 +20,7 @@
     "node": ">=10.13.0"
   },
   "dependencies": {
+    "domino": "^2.1.6",
     "tslib": "TSLIB_VERSION"
   },
   "peerDependencies": {

modules/aspnetcore-engine/src/interfaces/engine-render-result.ts

@@ -5,11 +5,9 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import { NgModuleRef } from '@angular/core';
 
 export interface IEngineRenderResult {
   html: string;
-  moduleRef: NgModuleRef<{}>;
   globals: {
     styles: string;
     title: string;

modules/aspnetcore-engine/src/main.ts

@@ -5,19 +5,17 @@
  * Use of this source code is governed by an MIT-style license that can be
  * found in the LICENSE file at https://angular.io/license
  */
-import { DOCUMENT } from '@angular/common';
-import { ResourceLoader } from '@angular/compiler';
-import { Compiler, CompilerFactory, NgModuleFactory, StaticProvider, Type } from '@angular/core';
-import { platformDynamicServer } from '@angular/platform-server';
+import { StaticProvider } from '@angular/core';
 
 import { ORIGIN_URL, REQUEST } from '@nguniversal/aspnetcore-engine/tokens';
-import { ɵFileLoader } from '@nguniversal/common/engine';
+import { ɵCommonEngine as CommonEngine, ɵRenderOptions as RenderOptions } from '@nguniversal/common/engine';
+import { createDocument } from 'domino';
 import { IEngineOptions } from './interfaces/engine-options';
 import { IEngineRenderResult } from './interfaces/engine-render-result';
-import { renderModuleFactory } from './platform-server-utils';
 
 /* @internal */
-function _getUniversalData(doc: Document, appSelector: string): Omit<IEngineRenderResult, 'moduleRef'> {
+function _getUniversalData(content: string, appSelector: string): IEngineRenderResult {
+  const doc = createDocument(content, true);
 
   const styles: string[] = [];
   const scripts: string[] = [];
@@ -63,6 +61,7 @@ function _getUniversalData(doc: Document, appSelector: string): Omit<IEngineRend
   };
 }
 
+const commonEngine = new CommonEngine();
 export async function ngAspnetCoreEngine(options: Readonly<IEngineOptions>)
   : Promise<IEngineRenderResult> {
   if (!options.appSelector) {
@@ -71,41 +70,20 @@ export async function ngAspnetCoreEngine(options: Readonly<IEngineOptions>)
      for your root App component.`);
   }
 
-  // Grab the DOM "selector" from the passed in Template <app-root> for example = "app-root"
-  const appSelector = options.appSelector.substring(1, options.appSelector.indexOf('>'));
-
-  const compilerFactory: CompilerFactory = platformDynamicServer().injector.get(CompilerFactory);
-  const compiler: Compiler = compilerFactory.createCompiler([
-    {
-      providers: [
-        { provide: ResourceLoader, useClass: ɵFileLoader, deps: [] }
-      ]
-    }
-  ]);
-
-  const moduleOrFactory = options.ngModule;
-  if (!moduleOrFactory) {
-    throw new Error('You must pass in a NgModule or NgModuleFactory to be bootstrapped');
-  }
-
-  const extraProviders = [
-    ...(options.providers || []),
-    getReqResProviders(options.request.origin, options.request.data.request),
-  ];
 
-  const factory = await getFactory(moduleOrFactory, compiler);
-  const result = await renderModuleFactory(factory, {
-    document: options.document || options.appSelector,
+  const renderOptions: RenderOptions = {
     url: options.url || options.request.absoluteUrl,
-    extraProviders,
-  });
+    document: options.document || options.appSelector,
+    providers: [...(options.providers || []), getReqResProviders(options.request.origin, options.request.data.request)],
+    bootstrap: options.ngModule,
+  };
 
-  const doc = result.moduleRef.injector.get(DOCUMENT);
 
-  return {
-    moduleRef: result.moduleRef,
-    ..._getUniversalData(doc, appSelector),
-  };
+  // Grab the DOM "selector" from the passed in Template <app-root> for example = "app-root"
+  const appSelector = options.appSelector.substring(1, options.appSelector.indexOf('>'));
+  const html = await commonEngine.render(renderOptions);
+
+  return _getUniversalData(html, appSelector);
 }
 
 /**
@@ -126,25 +104,3 @@ function getReqResProviders(origin: string, request: string): StaticProvider[] {
   return providers;
 }
 
-/* @internal */
-const factoryCacheMap = new Map<Type<{}>, NgModuleFactory<{}>>();
-async function getFactory(
-  moduleOrFactory: Type<{}> | NgModuleFactory<{}>, compiler: Compiler
-): Promise<NgModuleFactory<{}>> {
-  // If module has been compiled AoT
-  if (moduleOrFactory instanceof NgModuleFactory) {
-    return moduleOrFactory;
-  } else {
-    const moduleFactory = factoryCacheMap.get(moduleOrFactory);
-    // If module factory is cached
-    if (moduleFactory) {
-      return moduleFactory;
-    }
-
-    // Compile the module and cache it
-    const factory = await compiler.compileModuleAsync(moduleOrFactory);
-    factoryCacheMap.set(moduleOrFactory, factory);
-
-    return factory;
-  }
-}