Skip to content

Commit 68b392a

Browse files
committed
fix(@nguniversal/builders): bundle critters in common engine.
critters is shipped with ES2015 this that we cannot extend it when we use the UMD because a downlevelled class cannot extend an ES2015 class as it will cause `cannot be invoked without 'new'` With this change, critters will be included in the UMD bundle and downelevelled which would result in us being able to extend it. Closes angular#1970
1 parent d9a8a4f commit 68b392a

File tree

2 files changed

+1
-1
lines changed

2 files changed

+1
-1
lines changed

modules/common/BUILD.bazel

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ ng_package(
2828
deps = [
2929
":common",
3030
"//modules/common/engine",
31+
"@npm//critters",
3132
],
3233
)
3334

tools/defaults.bzl

-1
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ GLOBALS = {
7979
"@nguniversal/aspnetcore-engine/tokens": "nguniversal.aspnetcoreEngine.tokens",
8080
"@nguniversal/express-engine/tokens": "nguniversal.expressEngine.tokens",
8181
"@nguniversal/hapi-engine/tokens": "nguniversal.hapiEngine.tokens",
82-
"critters": "critters",
8382
"express": "express",
8483
"fs": "fs",
8584
"@hapi/hapi": "hapi.hapi",

0 commit comments

Comments
 (0)