fix(@angular/cli): only show add/update package install output on errors

clydin · clydin · commit 49817f07ff10 · 2019-11-01T22:13:21.000-04:00
Closes angular#16014 Closes angular#16027
diff --git a/packages/angular/cli/tasks/install-package.ts b/packages/angular/cli/tasks/install-package.ts
@@ -58,20 +58,24 @@ export function installPackage(
     }
   }
 
-  const { status } = spawnSync(
+  const { status, stderr } = spawnSync(
     packageManager,
     [
       ...installArgs,
       ...extraArgs,
     ],
     {
-      stdio: 'inherit',
-      shell: true,
+      stdio: 'pipe',
+      encoding: 'utf8',
     },
   );
 
   if (status !== 0) {
-    throw new Error('Package install failed, see above.');
+    let errors = stderr.trim();
+    if (errors.length) {
+      errors += '\n';
+    }
+    throw new Error(errors + `Package install failed${errors.length ? ', see above' : ''}.`);
   }
 
   logger.info(colors.green(`Installed packages for tooling via ${packageManager}.`));

Original file line number	Diff line number	Diff line change
`@@ -58,20 +58,24 @@ export function installPackage(`
`58`	`58`	`}`
`59`	`59`	`}`
`60`	`60`
`61`		`- const { status } = spawnSync(`
	`61`	`+ const { status, stderr } = spawnSync(`
`62`	`62`	`packageManager,`
`63`	`63`	`[`
`64`	`64`	`...installArgs,`
`65`	`65`	`...extraArgs,`
`66`	`66`	`],`
`67`	`67`	`{`
`68`		`- stdio: 'inherit',`
`69`		`- shell: true,`
	`68`	`+ stdio: 'pipe',`
	`69`	`+ encoding: 'utf8',`
`70`	`70`	`},`
`71`	`71`	`);`
`72`	`72`
`73`	`73`	`if (status !== 0) {`
`74`		`- throw new Error('Package install failed, see above.');`
	`74`	`+ let errors = stderr.trim();`
	`75`	`+ if (errors.length) {`
	`76`	`+ errors += '\n';`
	`77`	`+ }`
	`78`	+ throw new Error(errors + `Package install failed${errors.length ? ', see above' : ''}.`);
`75`	`79`	`}`
`76`	`80`
`77`	`81`	logger.info(colors.green(`Installed packages for tooling via ${packageManager}.`));