Skip to content

Commit 28721c3

Browse files
alkavats1alan-agius4
authored andcommitted
refactor(@angular/cli): improved code quality
removed unused parameter and improved code quality
1 parent af8dd62 commit 28721c3

File tree

6 files changed

+8
-9
lines changed

6 files changed

+8
-9
lines changed

lib/bootstrap-local.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,6 @@ const packages = require('./packages').packages;
8787
if (!__dirname.match(new RegExp(`\\${path.sep}node_modules\\${path.sep}`))) {
8888
// We mock the module loader so that we can fake our packages when running locally.
8989
const Module = require('module');
90-
const oldLoad = Module._load;
9190
const oldResolve = Module._resolveFilename;
9291

9392
Module._resolveFilename = function (request, parent) {

packages/angular/cli/src/commands/analytics/cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class AnalyticsCommandModule extends CommandModule implements CommandModu
2727
command = 'analytics';
2828
describe =
2929
'Configures the gathering of Angular CLI usage metrics. See https://angular.io/cli/usage-analytics-gathering';
30-
longDescriptionPath?: string | undefined;
30+
longDescriptionPath?: string;
3131

3232
builder(localYargs: Argv): Argv {
3333
const subcommands = [

packages/angular/cli/src/commands/analytics/info/cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export class AnalyticsInfoCommandModule
2020
{
2121
command = 'info';
2222
describe = 'Prints analytics gathering and reporting configuration in the console.';
23-
longDescriptionPath?: string | undefined;
23+
longDescriptionPath?: string;
2424

2525
builder(localYargs: Argv): Argv {
2626
return localYargs.strict();

packages/angular/cli/src/commands/analytics/settings/cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ abstract class AnalyticsSettingModule
2626
extends CommandModule<AnalyticsCommandArgs>
2727
implements CommandModuleImplementation<AnalyticsCommandArgs>
2828
{
29-
longDescriptionPath?: string | undefined;
29+
longDescriptionPath?: string;
3030

3131
builder(localYargs: Argv): Argv<AnalyticsCommandArgs> {
3232
return localYargs

packages/angular/cli/src/commands/doc/cli.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export class DocCommandModule
2828
aliases = ['d'];
2929
describe =
3030
'Opens the official Angular documentation (angular.io) in a browser, and searches for a given keyword.';
31-
longDescriptionPath?: string | undefined;
31+
longDescriptionPath?: string;
3232

3333
builder(localYargs: Argv): Argv<DocCommandArgs> {
3434
return localYargs

packages/angular/cli/src/commands/e2e/cli.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,19 +17,19 @@ export class E2eCommandModule
1717
multiTarget = true;
1818
override missingErrorTarget = tags.stripIndents`
1919
Cannot find "e2e" target for the specified project.
20-
20+
2121
You should add a package that implements end-to-end testing capabilities.
22-
22+
2323
For example:
2424
Cypress: ng add @cypress/schematic
2525
Nightwatch: ng add @nightwatch/schematics
2626
WebdriverIO: ng add @wdio/schematics
27-
27+
2828
More options will be added to the list as they become available.
2929
`;
3030

3131
command = 'e2e [project]';
3232
aliases = ['e'];
3333
describe = 'Builds and serves an Angular application, then runs end-to-end tests.';
34-
longDescriptionPath?: string | undefined;
34+
longDescriptionPath?: string;
3535
}

0 commit comments

Comments
 (0)