Skip to content

Commit 732011e

Browse files
adtian2Andrew Tian
and
Andrew Tian
authored
SMP PT 2.3 Fix (aws#4796)
* removing 2.3.0 as actual framework version is 2.3.1 * fixed framework_version from 2.3 to 2.3.1 * fixing unit test for PT 2.3 change * changing to correct smp version in unit test * changing logic around for unit test * printing variables * figured out bug in unit test where version is referring to pt, not smp version * trying logic a different way * version alias conficts resolved --------- Co-authored-by: Andrew Tian <[email protected]>
1 parent 6758bd6 commit 732011e

File tree

3 files changed

+7
-2
lines changed

3 files changed

+7
-2
lines changed

src/sagemaker/fw_utils.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,6 @@
152152
"2.1.0",
153153
"2.1.2",
154154
"2.2.0",
155-
"2.3.0",
156155
"2.3.1",
157156
]
158157

src/sagemaker/image_uri_config/pytorch-smp.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"2.1": "2.1.2",
99
"2.2": "2.3.1",
1010
"2.2.0": "2.3.1",
11-
"2.3": "2.4.0"
11+
"2.3.1": "2.4.0"
1212
},
1313
"versions": {
1414
"2.0.1": {

tests/unit/sagemaker/image_uris/test_smp_v2.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ def test_smp_v2(load_config):
2727
"torch_distributed": {"enabled": True},
2828
"smdistributed": {"modelparallel": {"enabled": True}},
2929
}
30+
3031
for processor in PROCESSORS:
3132
for version in VERSIONS:
3233
ACCOUNTS = load_config["training"]["versions"][version]["registries"]
@@ -38,6 +39,11 @@ def test_smp_v2(load_config):
3839
if "2.1" in version or "2.2" in version or "2.3" in version:
3940
cuda_vers = "cu121"
4041

42+
if "2.3.1" == version:
43+
py_version = "py311"
44+
45+
print(version, py_version)
46+
4147
uri = image_uris.get_training_image_uri(
4248
region,
4349
framework="pytorch",

0 commit comments

Comments
 (0)