Skip to content

Commit 2831956

Browse files
chalinkwalrath
authored andcommitted
docs(guide/user-input): follow-up to angular#1654 (angular#1770)
Mainly Dart-side review, following angular#1654: - Updates to follow style guide - Suites passed: public/docs/_examples/user-input/dart public/docs/_examples/user-input/ts Note: the click-me2 component is not mentioned in the prose, maybe it should be.
1 parent 3510f96 commit 2831956

File tree

4 files changed

+29
-25
lines changed

4 files changed

+29
-25
lines changed

public/docs/_examples/user-input/dart/lib/app_component.dart

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
import 'package:angular2/core.dart';
33

44
import 'click_me_component.dart';
5-
import 'click_me_component_2.dart';
5+
import 'click_me2_component.dart';
66
import 'keyup_components.dart';
77
import 'little_tour_component.dart';
88
import 'loop_back_component.dart';
@@ -12,7 +12,7 @@ import 'loop_back_component.dart';
1212
templateUrl: 'app_component.html',
1313
directives: const [
1414
ClickMeComponent,
15-
ClickMeComponent2,
15+
ClickMe2Component,
1616
KeyUpComponentV1,
1717
KeyUpComponentV2,
1818
KeyUpComponentV3,
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
// #docregion
2+
import 'package:angular2/core.dart';
3+
4+
@Component(
5+
selector: 'click-me2',
6+
template: '''
7+
<button (click)="onClickMe2(\$event)">No! .. Click me!</button>
8+
{{clickMessage}}''')
9+
class ClickMe2Component {
10+
String clickMessage = '';
11+
int _clicks = 1;
12+
13+
void onClickMe2(dynamic event) {
14+
var evtMsg =
15+
event != null ? ' Event target is ' + event.target.tagName : '';
16+
clickMessage = ('Click #${_clicks++}. ${evtMsg}');
17+
}
18+
}

public/docs/_examples/user-input/dart/lib/click_me_component.dart

+9-6
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,22 @@
1+
/* FOR DOCS ... MUST MATCH ClickMeComponent template
2+
// #docregion click-me-button
3+
<button (click)="onClickMe()">Click me!</button>
4+
// #enddocregion click-me-button
5+
*/
6+
17
// #docregion
28
import 'package:angular2/core.dart';
39

410
// #docregion click-me-component
511
@Component(
612
selector: 'click-me',
713
template: '''
8-
// #docregion click-me-button
9-
<button (click)="onClickMe()">Click me!</button>
10-
// #enddocregion click-me-button
11-
{{clickMessage}}''')
14+
<button (click)="onClickMe()">Click me!</button>
15+
{{clickMessage}}''')
1216
class ClickMeComponent {
1317
String clickMessage = '';
1418

15-
onClickMe() {
19+
void onClickMe() {
1620
clickMessage = 'You are my hero!';
1721
}
1822
}
19-
// #enddocregion click-me-component

public/docs/_examples/user-input/dart/lib/click_me_component_2.dart

-17
This file was deleted.

0 commit comments

Comments
 (0)