Skip to content

Commit a4b253d

Browse files
committed
Merge pull request #575 from lucasfcosta/clean-browser-before-karma
Clean browser before karma
2 parents e1b504c + 95a5056 commit a4b253d

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,12 +121,9 @@ git checkout -b <topic-branch-name>
121121

122122
4. Commit your changes in logical chunks. Use Git's [interactive rebase](https://help.github.com/articles/interactive-rebase) feature to tidy up your commits before making them public.
123123

124-
5. Run you code to make sure it works.
124+
5. Run you code to make sure it works. If you're still having problems please try to run `make clean` and then test your code again.
125125

126126
```bash
127-
npm i
128-
rm chai.js
129-
make chai.js
130127
npm test
131128
# when finished running tests...
132129
git checkout chai.js

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,17 +61,17 @@ test-cov: node_modules
6161
--require ./test/bootstrap \
6262
$(TESTS) \
6363

64-
test-phantom: chai.js
64+
test-phantom: clean-browser chai.js
6565
@printf "==> [Test :: Karma (PhantomJS)]\n"
6666
@./node_modules/karma/bin/karma start \
6767
--single-run --browsers PhantomJS
6868

69-
test-firefox: chai.js
69+
test-firefox: clean-browser chai.js
7070
@printf "==> [Test :: Karma (Firefox)]\n"
7171
@./node_modules/karma/bin/karma start \
7272
--browsers Firefox
7373

74-
test-sauce: chai.js
74+
test-sauce: clean-browser chai.js
7575
@printf "==> [Test :: Karma (Sauce)]\n"
7676
@CHAI_TEST_ENV=sauce ./node_modules/karma/bin/karma start \
7777
--single-run

0 commit comments

Comments
 (0)