Skip to content

Commit 1464bd6

Browse files
committed
Remove vue-cli dependencies
This started with an attempt to upgrade Astro to v3.0 - Astro v3.0 no longer supports Node 16. We need to upgrade our tooling to Node 18. See https://docs.astro.build/en/guides/upgrade-to/v3/#removed-support-for-node-16 - vue-cli contains a dependency that is not compatible with Node 18 (@achrinza/node-ipc@9). See vuejs/vue-cli#7116 This compatible issue has been fixed but Centrapay Docs does not need vue-cli and the module itself is in maintenance mode. See https://cli.vuejs.org/ Removing these vue-cli dependencies required a change to use eslint directly for linting instead. We are now using eslint-plugin-vue (it was already installed) as per Vue's official guidelines. See https://vuejs.org/guide/scaling-up/tooling.html#linting I've also added init: true to the docker compose config to forward signals correctly. Test plan: - Confirm Eslint is linting Vue files using its --debug flag - Confirm that the local dev server runs correctly - Confirm that the static Centrapay Docs site builds correctly - Confirm the site navigation still works
1 parent cf907af commit 1464bd6

File tree

3 files changed

+112
-5999
lines changed

3 files changed

+112
-5999
lines changed

docker-compose.yml

+4
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ version: "3"
33
services:
44
app:
55
image: node:16
6+
init: true
67
working_dir: /work
78
volumes: [ ".:/work" ]
89
command:
@@ -14,12 +15,14 @@ services:
1415
- "ENV=development"
1516
legacy:
1617
image: ruby:2.7
18+
init: true
1719
working_dir: /work/legacy
1820
volumes: [ ".:/work" ]
1921
command: "bundle exec jekyll serve --livereload --host=0.0.0.0"
2022
ports: [ "4000:4000", "35729:35729" ]
2123
script:
2224
image: node:16
25+
init: true
2326
working_dir: /work
2427
stop_signal: SIGKILL
2528
volumes: [ ".:/work" ]
@@ -32,6 +35,7 @@ services:
3235
docker-compose run script {command}"
3336
ruby-script:
3437
image: ruby:2.7
38+
init: true
3539
working_dir: /work/legacy
3640
volumes: [ ".:/work" ]
3741
stop_signal: SIGKILL

package.json

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"private": true,
33
"scripts": {
4-
"lint": "vue-cli-service lint --max-warnings 0 --no-fix .",
4+
"lint": "eslint --ext .js,.mjs,.ts,.vue .",
55
"dev": "astro dev",
66
"build": "astro build",
77
"preview": "astro preview",
@@ -16,8 +16,6 @@
1616
"@fontsource/inter": "^4.5.15",
1717
"@headlessui/vue": "^1.6.0",
1818
"@tailwindcss/typography": "^0.5.8",
19-
"@vue/cli-plugin-eslint": "~4.5.0",
20-
"@vue/cli-service": "~4.5.0",
2119
"astro": "^2.0.11",
2220
"eslint": "^7.20.0",
2321
"eslint-plugin-cypress": "^2.11.2",

0 commit comments

Comments
 (0)