Skip to content

Commit 35c8e31

Browse files
authored
chore: Update some dated comments (#2031)
* chore: Update some dated comments * Remove old protocol version comment
1 parent bac7831 commit 35c8e31

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

consensus/istanbul/backend/handler.go

-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ var (
3636
errDecodeFailed = errors.New("fail to decode istanbul message")
3737
)
3838

39-
// If you want to add a code, you need to increment the Lengths Array size!
4039
const (
4140
handshakeTimeout = 5 * time.Second
4241
)

consensus/istanbul/protocol.go

+1-10
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,6 @@ import (
2222

2323
// Constants to match up protocol versions and messages
2424
const (
25-
// No longer supported, can be removed.
26-
// The corresponding version upstream (eth/66) is removed in upstream PR #23120.
27-
// Celo66 = 66
28-
2925
// Supported versions
3026
Celo67 = 67 // incorporates changes from eth/66 (EIP-2481)
3127
)
@@ -38,13 +34,8 @@ const ProtocolName = "istanbul"
3834
var ProtocolVersions = []uint{Celo67}
3935

4036
// protocolLengths are the number of implemented message corresponding to different protocol versions.
41-
var ProtocolLengths = map[uint]uint64{Celo67: 25}
42-
43-
// NOTICE:
4437
// celo/67, uses as the last message the 0x18, so it has 25 messages (including the 0x00)
45-
// celo/66 has 27 as an unharm effect of removing 2 messages before the mainnet launch, that were
46-
// never updated with the actual number (https://github.com/celo-org/celo-blockchain/pull/893)
47-
// The Celo66 protocol has actually 25 messages, but we keep it with 27 to avoid problems.
38+
var ProtocolLengths = map[uint]uint64{Celo67: 25}
4839

4940
// Message codes for istanbul related messages
5041
// If you want to add a code, you need to increment the protocolLengths Array size

0 commit comments

Comments
 (0)