Merge branch 'fix_issue_453' into refactor_v1

* fix_issue_453:
  Fix test to check against ui-select-offscreen class, not ng-hide
  Update to move search box off screen
  Don't hide select when SearchEnable is false angular-ui#453

Conflicts:
	examples/bootstrap.html

Author: cdjackson

src/bootstrap/select.tpl.html

@@ -8,6 +8,6 @@
          class="form-control ui-select-search"
          placeholder="{{$select.placeholder}}"
          ng-model="$select.search"
-         ng-show="$select.searchEnabled && $select.open">
+         ng-show="$select.open">
   <div class="ui-select-choices"></div>
 </div>

src/uiSelectController.js

@@ -79,6 +79,9 @@ uis.controller('uiSelectCtrl',
       $scope.$broadcast('uis:activate');
 
       ctrl.open = true;
+      if(!ctrl.searchEnabled) {
+        angular.element(ctrl.searchInput[0]).addClass('ui-select-offscreen');
+      }
 
       ctrl.activeIndex = ctrl.activeIndex >= ctrl.items.length ? 0 : ctrl.activeIndex;
 
@@ -94,6 +97,10 @@ uis.controller('uiSelectCtrl',
         ctrl.searchInput[0].focus();
       });
     }
+    else if (ctrl.open && !ctrl.searchEnabled) {
+      // Close the selection if we don't have search enabled, and we click on the select again
+      ctrl.close();
+    }
   };
 
   ctrl.findGroupByName = function(name) {
@@ -331,6 +338,9 @@ uis.controller('uiSelectCtrl',
     if (ctrl.ngModel && ctrl.ngModel.$setTouched) ctrl.ngModel.$setTouched();
     _resetSearchInput();
     ctrl.open = false;
+    if(!ctrl.searchEnabled) {
+      angular.element(ctrl.searchInput[0]).removeClass('ui-select-offscreen');
+    }
 
     $scope.$broadcast('uis:close', skipFocusser);
 

test/select.spec.js

@@ -1497,13 +1497,13 @@ describe('ui-select tests', function() {
       it('should show search input when true', function() {
         setupSelectComponent('true', 'bootstrap');
         clickMatch(el);
-        expect($(el).find('.ui-select-search')).not.toHaveClass('ng-hide');
+        expect($(el).find('.ui-select-search')).not.toHaveClass('ui-select-offscreen');
       });
 
       it('should hide search input when false', function() {
         setupSelectComponent('false', 'bootstrap');
         clickMatch(el);
-        expect($(el).find('.ui-select-search')).toHaveClass('ng-hide');
+        expect($(el).find('.ui-select-search')).toHaveClass('ui-select-offscreen');
       });
 
     });