Revert overrides since these aren't needed after databricks#328

Signed-off-by: Jesse Whitehouse <[email protected]>

Author: Jesse Whitehouse

src/databricks/sqlalchemy/test/_extra.py

@@ -3,9 +3,6 @@
 
 import datetime
 
-from sqlalchemy import Integer, String, schema, inspect
-from sqlalchemy.testing import util
-from sqlalchemy.testing.config import requirements
 from sqlalchemy.testing.suite.test_types import (
     _LiteralRoundTripFixture,
     fixtures,
@@ -66,39 +63,8 @@ class DateTimeTZTestCustom(_DateFixture, fixtures.TablesTest):
 
     @testing.requires.datetime_implicit_bound
     def test_select_direct(self, connection):
+
         # We need to pass the TIMESTAMP type to the literal function
         # so that the value is processed correctly.
         result = connection.scalar(select(literal(self.data, TIMESTAMP)))
         eq_(result, self.data)
-
-
-class TableDDLTestCustom(fixtures.TestBase):
-    """This test confirms that a table comment can be dropped.
-    The difference with TableDDLTest is that the comment value is '' and not None after
-    being dropped.
-    """
-
-    __backend__ = True
-
-    def _simple_fixture(self, schema=None):
-        return Table(
-            "test_table",
-            self.metadata,
-            Column("id", Integer, primary_key=True, autoincrement=False),
-            Column("data", String(50)),
-            schema=schema,
-        )
-
-    @requirements.comment_reflection
-    @util.provide_metadata
-    def test_drop_table_comment(self, connection):
-        table = self._simple_fixture()
-        table.create(connection, checkfirst=False)
-        table.comment = "a comment"
-        connection.execute(schema.SetTableComment(table))
-        connection.execute(schema.DropTableComment(table))
-        eq_(inspect(connection).get_table_comment("test_table"), {"text": ""})
-
-
-class FutureTableDDLTestCustom(fixtures.FutureEngineMixin, TableDDLTestCustom):
-    pass

src/databricks/sqlalchemy/test/_unsupported.py

@@ -55,7 +55,6 @@ class SkipReason(Enum):
     TIMEZONE_OPT = "timezone-optional TIMESTAMP fields"
     TRANSACTIONS = "transactions"
     UNIQUE = "UNIQUE constraints"
-    DROP_TBL = "drop table comment"
 
 
 def render_skip_reason(rsn: SkipReason, setup_error=False, extra=False) -> str:
@@ -223,13 +222,6 @@ def test_uuid_returning(self):
 
 
 class FutureTableDDLTest(FutureTableDDLTest):
-    @pytest.mark.skip(reason=render_skip_reason(SkipReason.DROP_TBL))
-    def test_drop_table_comment(self, connection):
-        """The DropTableComment statement is supported but it sets the comment to ''
-        instead of None so this test can't pass.
-        """
-        pass
-
     @pytest.mark.skip(render_skip_reason(SkipReason.INDEXES))
     def test_create_index_if_not_exists(self):
         """We could use requirements.index_reflection and requirements.index_ddl_if_exists
@@ -246,13 +238,6 @@ def test_drop_index_if_exists(self):
 
 
 class TableDDLTest(TableDDLTest):
-    @pytest.mark.skip(reason=render_skip_reason(SkipReason.DROP_TBL))
-    def test_drop_table_comment(self, connection):
-        """The DropTableComment statement is supported but it sets the comment to ''
-        instead of None so this test can't pass.
-        """
-        pass
-
     @pytest.mark.skip(reason=render_skip_reason(SkipReason.INDEXES))
     def test_create_index_if_not_exists(self, connection):
         """We could use requirements.index_reflection and requirements.index_ddl_if_exists

src/databricks/sqlalchemy/test/test_suite.py

@@ -10,9 +10,4 @@
 from databricks.sqlalchemy.test._regression import *
 from databricks.sqlalchemy.test._unsupported import *
 from databricks.sqlalchemy.test._future import *
-from databricks.sqlalchemy.test._extra import (
-    TinyIntegerTest,
-    DateTimeTZTestCustom,
-    TableDDLTestCustom,
-    FutureTableDDLTestCustom
-)
+from databricks.sqlalchemy.test._extra import TinyIntegerTest, DateTimeTZTestCustom