spring-projectsGH-2544 Neo4jTemplate.saveAllAs returns emptyList when given empty iterable.

Author: cberes

src/main/java/org/springframework/data/neo4j/core/Neo4jTemplate.java

@@ -520,6 +520,10 @@ public <T, R> List<R> saveAllAs(Iterable<T> instances, Class<R> resultType) {
 
 		Assert.notNull(resultType, "ResultType must not be null!");
 
+		if (!instances.iterator().hasNext()) {
+			return Collections.emptyList();
+		}
+
 		Class<?> commonElementType = TemplateSupport.findCommonElementType(instances);
 
 		if (resultType.isAssignableFrom(commonElementType)) {

src/test/java/org/springframework/data/neo4j/integration/imperative/Neo4jTemplateIT.java

@@ -795,6 +795,13 @@ void saveAllAsWithClosedProjectionShouldWork() {
 		assertThat(people).allMatch(p -> p.getAddress() != null);
 	}
 
+	@Test
+	void saveAllAsWithEmptyList() {
+		List<ClosedProjection> projections = neo4jTemplate.saveAllAs(Collections.emptyList(), ClosedProjection.class);
+
+		assertThat(projections).isEmpty();
+	}
+
 	@Test
 	void updatingFindShouldWork() {
 		Map<String, Object> params = new HashMap<>();